The download is implemented as functions in a module
Metadata
Current evaluation
Download logic moved into StoreClient by ubuntu-core/snapcraft#530 (commit 0425b6375), resolving launchpad/snapcraft#1586836 without changing commands.
Resolution: closed resolved
Reason: ubuntu-core/snapcraft#530 implemented the change in commit 0425b6375 and shipped in Snapcraft 2.10. The maintainer verified that snapcraft pull successfully downloaded the OS snap, after which verification was completed.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Just like in bug #1586504, we can improve the download code by moving the download to the StoreClient object.
[Impact]
* No visual impact for users, the commands are untouched.
* This change improves the existing code, but also allows us to make an easier landing of the macaroons feature.
[Test Case]
* snapcraft login.
* go to the 96boards example
* snapcraft clean
* snapcraft pull
* check that os snap was downloaded.
[Regression Potential]
* The download of snaps might fail.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Download logic moved into StoreClient by ubuntu-core/snapcraft#530 (commit 0425b6375), resolving launchpad/snapcraft#1586836 without changing commands. | |
| stealth/space-bunny-alpha | — | closed resolved | Refactor landed: PR #530 (commit 0425b6375) moved the download logic from module-level functions into StoreClient, unblocking macaroon support (#532). Verified on xenial with snapcraft 2.10.1 and closed as fixed in Launchpad LP #1586836. | |
| stealth/space-bunny-alpha | — | closed resolved | Download logic was moved into StoreClient, resolving the refactor in snapcraft/snapcraft#530 (commit 0425b6375). | |
| qwen/qwen3.6-35b-a3b | — | — | Download logic refactored into the StoreClient object to improve code structure and enable the macaroons feature. The change was implemented, verified, and closed with no user-facing impact. | |
| qwen/qwen3.6-35b-a3b | — | — | Download logic refactored into the StoreClient object to improve code structure and support the macaroons feature. Implementation verified and issue closed. |
Update history
| Date | Change |
|---|---|
| created |
Related work
-
Likely Fixed By:
ubuntu-core/snapcraft#530
(confidence 100%)
Merged change that moved download handling into StoreClient.
-
Related To:
ubuntu-core/snapcraft#532
(confidence 95%)
Follow-up PR adding macaroon support to login, upload, and download.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #530 Moved the download to the store client. | snapcraft | merged | Merged download handling into the store client in canonical/snapcraft#530, resolving LP #1586836; commit 0425b6375. | |
| #1586874 The upload is implemented as functions in a module | snapcraft (launchpad) | closed | Refactor landed: upload moved from module-level functions into StoreClient by canonical/snapcraft#531 (commit 7d25cebcc), following the download refactor #530; LP bug closed by maintainer elopio. |