← Back to issue list

The upload is implemented as functions in a module

View original Launchpad issue

Metadata

Project
snapcraft (launchpad)
Number
#1586874
Type
issue
State
closed
Author
~elopio
Labels
—
Created
Updated
Closed

Current evaluation

Refactor landed: upload moved from module-level functions into StoreClient by canonical/snapcraft#531 (commit 7d25cebcc), following the download refactor #530; LP bug closed by maintainer elopio.

Resolution: closed resolved

Reason: The maintainer's closing comment links PR #531, which merged as commit 7d25cebcc ("Moved the upload to the store client. (#531)"), completing the move of store interactions into the client object requested in the bug and the prerequisite download refactor #530 (0425b6375).

Evaluated by: mr-cal-bot

No scores available.

Issue body

Just like in bug #1586504, we can improve the upload code by moving the download to the StoreClient object. [Impact]  * No visual impact for users, the commands are untouched.  * This change improves the existing code, but also allows us to make an easier landing of the macaroons feature. [Test Case]  * snapcraft login.  * build a snap  * snapcraft upload <path.snap>  * check that os snap was uploaded by going to myapps. [Regression Potential]  * The upload of snaps might fail.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Refactor landed: upload moved from module-level functions into StoreClient by canonical/snapcraft#531 (commit 7d25cebcc), following the download refactor #530; LP bug closed by maintainer elopio.
stealth/space-bunny-alpha — closed resolved Refactor request implemented: upload handling was moved from module-level functions into StoreClient by merged PR canonical/snapcraft#531 (commit 7d25cebcc), following prerequisite download refactor #530 (0425b6375).
stealth/space-bunny-alpha — closed resolved Merged canonical/snapcraft#531 (7d25cebcc), moving snap uploads from module functions into StoreClient to ease macaroons support.
stealth/space-bunny-alpha — closed resolved Upload handling was moved into StoreClient by merged PR canonical/snapcraft#531 (commit 7d25cebcc), following the prerequisite download refactor in #530.
qwen/qwen3.6-35b-a3b — — Proposed upload refactoring to StoreClient was closed without implementation. No pull request was merged, and the change appears abandoned.
qwen/qwen3.6-35b-a3b — — Abandoned. Refactoring upload code to StoreClient was closed without implementation or discussion. No pull request was created.

Update history

Date Change
created

Related work

  • Likely Fixed By: canonical/snapcraft#531 (confidence 98%)

    Merged PR cited in the closing comment; commit 7d25cebcc moved upload logic into the store client.

  • Related To: canonical/snapcraft#530 (confidence 90%)

    Prerequisite refactor moving download into the store client (commit 0425b6375).

  • Related To: snapcraft (launchpad)#1586504 (confidence 85%)

    Original refactor bug establishing client objects; this upload change was the follow-up referenced in its description.

  • Related To: canonical/snapcraft#532 (confidence 60%)

    Follow-up PR adding macaroon support to login, upload and download, the motivating goal cited in the bug.

Related issues

Issue Project State Summary Similarity
#531 Moved the upload to the store client. snapcraft merged Merged PR #531 in commit 7d25cebcc, moving upload handling from Snapcraft into the store client after the download migration in #530.
74%
#1586836 The download is implemented as functions in a module snapcraft (launchpad) closed Download logic moved into StoreClient by ubuntu-core/snapcraft#530 (commit 0425b6375), resolving launchpad/snapcraft#1586836 without changing commands.
73%