← Back to issue list

unit tests are not using testtools

View original Launchpad issue

Metadata

Project
snapcraft (launchpad)
Number
#1593079
Type
issue
State
closed
Author
~elopio
Labels
—
Created
Updated
Closed

Current evaluation

Unit tests migrated to use testtools as their base class. Work landed across PR #943 and the follow-up PR #948 (commit 2eaf421a7, "tests: use testtools as the base of all unit tests"), which closed the bug.

Resolution: closed resolved

Reason: Maintainer elopio closed the bug pointing at PR #948, merged as commit 2eaf421a7 "tests: use testtools as the base of all unit tests". The earlier PR #943 was partial (elopio noted it was "missing another massive change of all the 300 assertRaises"), which #948 completed.

Evaluated by: mr-cal-bot

No scores available.

Issue body

testtools is used in the integration and snaps test suites. It would be nice to use it in the unittests too. [Impact] * For users, None. * Testtools adds extra features that we will be able to use in unittests. [Test Case] * N/A [Regression Potential] * This could make unit tests fail. They are executed before merging the branch into master, so we are covered.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Unit tests migrated to use testtools as their base class. Work landed across PR #943 and the follow-up PR #948 (commit 2eaf421a7, "tests: use testtools as the base of all unit tests"), which closed the bug.
stealth/space-bunny-alpha — closed resolved Unit tests converted to testtools: snapcraft/snapcraft#943 replaced subTests with TestScenarios and merged PR #948 (commit 2eaf421a7) made testtools the base of all unit tests (~50 files changed, ~97% coverage kept).
stealth/space-bunny-alpha — closed resolved Unit tests were migrated to testtools by snapcraft PR #948 (commit 2eaf421a7), making testtools the base for all unit tests.
qwen/qwen3.6-35b-a3b — — Adopting testtools for unit tests was closed without implementation. No pull requests or comments were created, indicating the enhancement was abandoned.
qwen/qwen3.6-35b-a3b — — Closed without implementation or discussion, the request to adopt testtools for unit tests was abandoned or superseded by newer testing frameworks.
qwen/qwen3.6-35b-a3b — — Requesting unit tests adopt testtools was closed without implementation. The suggestion was abandoned with no code changes or follow-up.
qwen3.6-35b-a3b-mtp-q6 — — Closed without implementation. The proposal to adopt testtools for unit tests was abandoned or superseded by later framework updates, with no code changes or discussion recorded.

Update history

Date Change
created

Related work

  • Likely Fixed By: snapcore/snapcraft#948 (confidence 98%)

    Merged as commit 2eaf421a7; cited by the reporter as the change that closed the bug.

  • Related To: snapcore/snapcraft#943 (confidence 90%)

    Earlier partial attempt converting unit tests to testtools, left the assertRaises conversion unfinished.

  • Blocked By: testtools#235 (confidence 70%)

    Upstream testtools issue about subTest support missing, which clashed with testscenarios usage.

Related issues

Issue Project State Summary Similarity
#948 Use testtools as the base of all unit tests snapcraft merged PR #948 merged as commit 2eaf421a7, converting all Snapcraft unit tests to base on testtools (LP #1593079); ~50 files changed, coverage held at ~97%. PR #943 (subTests -> TestScenarios) preceded it.
74%
#272 Fix the examples tests using testtools as the base. snapcraft merged Merged PR #272 updated the examples tests to use testtools, fixing LP #1539196 in commit 5f39d00e9 (merge 7e5a479ae).
72%