Use testtools as the base of all unit tests
Metadata
Current evaluation
PR #948 merged as commit 2eaf421a7, converting all Snapcraft unit tests to base on testtools (LP #1593079); ~50 files changed, coverage held at ~97%. PR #943 (subTests -> TestScenarios) preceded it.
Resolution: closed resolved
Reason: The pull request itself was merged into master as commit 2eaf421a7 ("tests: use testtools as the base of all unit tests (#948)"), closing Launchpad bug #1593079 with ~97% coverage retained.
Evaluated by: mr-cal-bot
Issue body
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | PR #948 merged as commit 2eaf421a7, converting all Snapcraft unit tests to base on testtools (LP #1593079); ~50 files changed, coverage held at ~97%. PR #943 (subTests -> TestScenarios) preceded it. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #948 in commit 2eaf421a7, converting all Snapcraft unit tests to derive from testtools for LP #1593079. | |
| stealth/space-bunny-alpha | — | closed resolved | PR #948 by maintainer come-maiz was merged (commit 2eaf421a7, +969/-727, 50 files), converting all Snapcraft unit tests to testtools as the base, fixing LP bug #1593079 while keeping ~97% coverage. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR snapcraft#948 (commit 2eaf421a7) converting all snapcraft unit tests to testtools as their base, changing 50 files (+969/-727) while holding ~97% coverage; closes Launchpad bug LP #1593079. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #948 (commit 2eaf421a7) converted all Snapcraft unit tests to the testtools base (50 files, +969/-727) for LP #1593079; codecov reported coverage held at ~97%. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #948 (2eaf421a7), standardizing all Snapcraft unit tests on testtools; 50 files changed while preserving approximately 97% coverage. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged changes to adopt testtools as the base framework for all unit tests. Approved by a maintainer, the update modified 50 files, reduced code by 236 lines, and maintained 97% coverage. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into master, replacing the unit test base with testtools. The change addresses LP #1593079 and achieved 100% diff coverage, with Codecov noting a negligible 0.03% overall coverage decrease. |
Update history
No update history recorded yet.
Related work
-
Related To:
snapcraft#943
(confidence 92%)
Merged PR replacing subTests with testtools TestScenarios across 12 test files as part of the same LP #1593079 effort
-
Related To:
snapcraft (launchpad)#1593079
(confidence 80%)
Launchpad bug 'unit tests are not using testtools' referenced in the PR body; closed by this work
-
Related To:
snapcraft#1391
(confidence 45%)
Later commit 'tests: reduce the amount of test code in test_meta (#1391)' continues simplifying testtools-based tests
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #943 Replace subTests with TestScenarios | snapcraft | merged | Merged #943, replacing subTests with testtools TestScenarios across 12 test files as the first step toward the LP: #1593079 migration. | |
| #1593079 unit tests are not using testtools | snapcraft (launchpad) | closed | Unit tests migrated to use testtools as their base class. Work landed across PR #943 and the follow-up PR #948 (commit 2eaf421a7, "tests: use testtools as the base of all unit tests"), which closed the bug. | |
| #272 Fix the examples tests using testtools as the base. | snapcraft | merged | Merged PR #272 updated the examples tests to use testtools, fixing LP #1539196 in commit 5f39d00e9 (merge 7e5a479ae). |