← Back to issue list

Use testtools as the base of all unit tests

View original Github issue

Metadata

Project
snapcraft
Number
#948
Type
pull request
State
merged
Author
come-maiz
Labels
Created
Updated
Closed

Current evaluation

Merged changes to adopt testtools as the base framework for all unit tests. Approved by a maintainer, the update modified 50 files, reduced code by 236 lines, and maintained 97% coverage.

Suggested action:

No scores available.

Issue body

LP: #1593079

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged changes to adopt testtools as the base framework for all unit tests. Approved by a maintainer, the update modified 50 files, reduced code by 236 lines, and maintained 97% coverage.
qwen3.6-35b-a3b-mtp-q6 Merged into master, replacing the unit test base with testtools. The change addresses LP #1593079 and achieved 100% diff coverage, with Codecov noting a negligible 0.03% overall coverage decrease.
qwen3.6-35b-a3b-mtp-q6 Merged the migration to testtools as the base framework for all unit tests. The change reduced the test suite by 236 lines and decreased overall coverage by 0.03% while maintaining 100% diff coverage.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#272 Fix the examples tests using testtools as the base. snapcraft merged Merged a fix updating example tests to use testtools as the base, resolving Launchpad bug #1539196. The change modified one file with two additions and one deletion, integrating directly without reviewer approval or CI checks.
75%
#7 tools: Split unit and integration tests starbase merged Merged changes splitting unit and integration tests into separate directories. Approved by one reviewer. The update modifies six files, adding 33 net lines. The integration folder was created solely for structural separation.
74%
#172 tools: update external testing tools rockcraft merged Merged after approval by two reviewers. The update refreshes the external testing tools submodule, modifying two files with a minimal diff of two additions and one deletion. No unresolved comments or CI issues were present.
73%
#1391 tests: reduce the amount of test code in test_meta snapcraft merged Merged updates that streamlined test_meta by utilizing the _create_file helper and testtools. Approved by one reviewer, the commit reduced code by 31 lines across a single file.
73%
#943 Replace subTests with TestScenarios snapcraft merged Merged following reviewer approval. Replaced subTests with TestScenarios across 12 files to initiate migration to testtools. Changes totaled +1111/-1064 lines while maintaining 97.09% test coverage.
70%