← Back to issue list

upload integration test is not using a unique name

View original Launchpad issue

Metadata

Project
snapcraft (launchpad)
Number
#1595319
Type
issue
State
closed
Author
~elopio
Labels
verification-done
Created
Updated
Closed

Current evaluation

Fixed by canonical/snapcraft#595 ("Fix the store update test to register a unique name"), commit d5daf8c9c, merged June 2016 and released in snapcraft 2.12 via xenial SRU; elopio set verification-done, then closed.

Resolution: closed resolved

Reason: The integration upload test now registers a unique snap name, implemented in upstream PR #595 (commit d5daf8c9c), cited by elopio in the 2016-06-22 comment. The fix shipped in snapcraft 2.12 to xenial -proposed/-updates and the author closed the bug marking verification-done.

Evaluated by: mr-cal-bot

No scores available.

Issue body

If the upload test doesn't use a unique name, then it can't be executed by a user that we don't control and have previously set up. I tried to do this in a previous branch but left a bug which makes it use the old snap name. [Impact] * For users, none. * For developers, this forces us to share the staging test account password in order to run the tests. [Test Case] * Run: <email address hidden> TEST_USER_PASSWORD=Hola123* ./runtests.sh integration test_store_upload.py (replacing the credentials with some staging user with the developer agreement signed. [Regression Potential] * This could make the staging store tests fail.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Fixed by canonical/snapcraft#595 ("Fix the store update test to register a unique name"), commit d5daf8c9c, merged June 2016 and released in snapcraft 2.12 via xenial SRU; elopio set verification-done, then closed.
stealth/space-bunny-alpha — closed resolved Fixed by canonical/snapcraft#595 ("Fix the store update test to register a unique name", commit d5daf8c9c), merged 2016-06 and released via snapcraft 2.12 SRU to xenial; author marked verification-done after xenial-proposed.
stealth/space-bunny-alpha — closed resolved Store upload integration testing was fixed to register a unique name in snapcraft#595 (commit d5daf8c9c), avoiding shared staging credentials.
qwen/qwen3.6-35b-a3b — — Fixed the upload integration test to use unique names, removing the requirement for shared staging credentials. The change was implemented, verified, and the issue closed.
qwen/qwen3.6-35b-a3b — — Fixed by updating the upload integration test to generate unique names, removing the need to share staging credentials. Resolved and verified.
qwen/qwen3.6-35b-a3b — — Fixed the upload integration test to generate unique names, preventing account conflicts and removing the need to share staging credentials. The resolution was implemented and verified, closing the issue.
qwen3.6-35b-a3b-mtp-q6 — — Fixed by updating the upload integration test to use unique names, removing the need to share staging credentials. Verified and closed.

Update history

Date Change
created

Related work

  • Likely Fixed By: canonical/snapcraft#595 (confidence 95%)

    PR 'Fix the store update test to register a unique name', merged as commit d5daf8c9c.

Related issues

Issue Project State Summary Similarity
#1964 Fix Store integration tests with updated snap name registration error messages (take 2) snapcraft merged Merged in canonical/snapcraft#1964 as commit 44ecb321a, updating Store integration tests for new snap-name registration errors; it supersedes #1963.
72%
#1247 Fixing Store integration tests. snapcraft merged Merged in canonical/snapcraft#1247 as 03105a6c4, updating Store integration tests and registration error handling for the new 40-character snap-name limit.
71%