Fix Store integration tests with updated snap name registration error messages (take 2)
Metadata
Current evaluation
Merged in canonical/snapcraft#1964 as commit 44ecb321a, updating Store integration tests for new snap-name registration errors; it supersedes #1963.
Resolution: closed resolved
Reason: PR #1964 merged as commit 44ecb321a, adapting Store integration-test assertions to the updated error messages. It also incorporated and superseded the earlier attempt in #1963.
Evaluated by: mr-cal-bot
No scores available.
Issue body
This starts from @maxiberta's #1963 and fixes a couple more strings.
Here goes nothing.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged in canonical/snapcraft#1964 as commit 44ecb321a, updating Store integration tests for new snap-name registration errors; it supersedes #1963. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged as commit 44ecb321a, updating Store integration tests for revised snap-name registration errors and fixing additional messages omitted by #1963. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #1964 (commit 44ecb321a), updating Store integration tests for new snap-name registration error messages; it supersedes the earlier attempt in #1963. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged after approval, updating Store integration tests to match new snap name registration error messages. Builds on PR #1963, modifying string literals across three files. Resolved with zero outstanding comments. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged updates to Store integration tests aligning with revised snap name registration error messages. Builds on #1963, correcting additional string references to restore test compatibility. |
Update history
No update history recorded yet.
Related work
-
Related To:
canonical/snapcraft#1963
(confidence 100%)
Initial attempt that PR #1964 continued from after additional error strings needed correction.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1247 Fixing Store integration tests. | snapcraft | merged | Merged in canonical/snapcraft#1247 as 03105a6c4, updating Store integration tests and registration error handling for the new 40-character snap-name limit. | |
| #1963 Fix Store integration tests with updated snap name registration error messages | snapcraft | closed | PR #1963 (maxiberta) updated Store integration tests for new snap-name validation errors but was closed unmerged by the author on 2018-02-28 in favour of #1964, which merged as commit 44ecb321a. | |
| #1797 tests: update the snap name already registered for store tests | snapcraft | merged | Updated store tests to use a currently registered, non-revoked snap after the previous test name was revoked; merged as commit 4cf4f33a. | |
| #1595319 upload integration test is not using a unique name | snapcraft (launchpad) | closed | Fixed by canonical/snapcraft#595 ("Fix the store update test to register a unique name"), commit d5daf8c9c, merged June 2016 and released in snapcraft 2.12 via xenial SRU; elopio set verification-done, then closed. | |
| #1625 tests: use the snapcraft snap for integration tests | snapcraft | merged | Merged PR #1625 updated integration tests to run the installed Snapcraft snap, better matching the user environment. Resolution: commit eebb070e6. | |
| #839 Fixing 'sign-build' integration tests. | snapcraft | merged | Merged in canonical/snapcraft#839 as commit b67a60d58, fixing sign-build integration tests by registering snap names and exposing them through the fake account-info endpoint. | |
| #2505 Test store | snapcraft | merged | Merged PR #2505 updated a Snapcraft test in one file (+16/-8); no release or resolving commit SHA was provided. | |
| #2086 tests: update metadata store integration test, no previous push required | snapcraft | merged | Merged PR #2086 in commit 3882853b7, updating the metadata-store integration test for approved snap names whose metadata can be changed before any revision push. | |
| #631 Fix the store integration tests | snapcraft | merged | Merged PR #631 (commit 351d4aaac) fixed store integration tests by pausing after rapid snap registrations so later tests did not inherit the rate-limit error. | |
| #4863 fix(cli): properly capture store errors | snapcraft | merged | Merged #4863 in commit 426df7ec3, restoring legacy-style store-error capture so store failures are no longer reported as Snapcraft internal errors. |