unnecessary clean on examples tests
Metadata
Current evaluation
Removed the redundant clean before snaps example tests via snapcraft#637 (commit 1a92db54f), speeding tests and reducing hung clean processes.
Resolution: closed resolved
Reason: Merged PR canonical/snapcraft#637 removed the unnecessary cleanup while retaining integration coverage for the clean command.
Evaluated by: mr-cal-bot
No scores available.
Issue body
On the snaps tests, we start by cleaning the project each time before snapping. That's unnecessary, because in jenkins and autopkgtests the directories start clean. For local devs, we can assume the same.
By removing the clean, the tests will be a little faster. And yesterday some slaves were full of hanging snapcraft clean processes, so there will be one less problem to debug. The clean command is tested in integration, so this doesn't reduce coverage.
[Impact]
* For users, none.
* For developers, faster and more stable tests.
[Test Case]
* N/A
[Regression Potential]
* The tests could start failing. But that would block the fix to land into master so we are covered.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Removed the redundant clean before snaps example tests via snapcraft#637 (commit 1a92db54f), speeding tests and reducing hung clean processes. | |
| stealth/space-bunny-alpha | — | closed resolved | Removed unnecessary cleaning before snaps tests, improving speed and avoiding hung clean processes; merged in canonical/snapcraft#637 as 1a92db54f. | |
| stealth/space-bunny-alpha | — | closed resolved | Removed the unnecessary pre-test clean in merged PR canonical/snapcraft#637 (commit 1a92db54f), speeding up snaps tests and reducing hangs from clean processes. | |
| qwen/qwen3.6-35b-a3b | — | — | Closed after implementing the removal of the unnecessary snapcraft clean step from examples tests. The change improves test speed and stability while maintaining coverage through existing integration tests. | |
| qwen/qwen3.6-35b-a3b | — | — | Closed after implementing the removal of the unnecessary snapcraft clean step from examples tests. This improves test speed and stability while maintaining coverage through integration tests. | |
| qwen/qwen3.6-35b-a3b | — | — | Closed as fixed. The unnecessary snapcraft clean step was removed from examples tests to speed up execution and prevent CI hangs, improving test stability without reducing coverage. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Removed the unnecessary snapcraft clean step from examples tests, improving execution speed and stability without reducing coverage. The change was implemented and the issue closed. |
Update history
| Date | Change |
|---|---|
| created |
Related work
-
Likely Fixed By:
canonical/snapcraft#637
(confidence 100%)
Merged in commit 1a92db54f and explicitly updated the Launchpad issue as fixed.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #637 Do not clean before running the snaps tests | snapcraft | merged | Merged in snapcraft#637 via commit 1a92db54f, preserving existing artifacts before snaps tests and updating conflicts for LP #1599957. | |
| #85 test: cleanup test now that we have a new enough snapcraft | snapcraft-rocks | merged | Merged in snapcraft-rocks#85, removing six obsolete test lines after upgrading past the stable Snapcraft behavior delivered by canonical/snapcraft#4666. | |
| #1007 lifecycle: clean without parsing if possible. | snapcraft | merged | Merged in snapcraft#1007 via commit bacf75dfe, allowing full clean operations to bypass snapcraft.yaml parsing unless part-specific cleanup is required. | |
| #1578170 Your first snap: snapcraft clean needed before second snapcraft stage | snapcraft (launchpad) | closed | Fixed in canonical/snapcraft#4 by PRs #442–#448 (commits 1a6a21831, 80de92254, 6224553ae, da1411df0): snapcraft.yaml changes now dirty lifecycle steps, avoiding the required manual clean. |