test: cleanup test now that we have a new enough snapcraft
Metadata
Current evaluation
Merged in snapcraft-rocks#85, removing six obsolete test lines after upgrading past the stable Snapcraft behavior delivered by canonical/snapcraft#4666.
Resolution: closed resolved
Reason: PR #85 was approved and merged with all CI checks passing. Its cleanup removed outdated test code that was unnecessary after the Snapcraft upgrade.
Evaluated by: mr-cal-bot
No scores available.
Issue body
https://github.com/canonical/snapcraft/pull/4666 is stable and we're upgraded past that version so we can fix this test.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged in snapcraft-rocks#85, removing six obsolete test lines after upgrading past the stable Snapcraft behavior delivered by canonical/snapcraft#4666. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in snapcraft-rocks#85, removing six lines of obsolete test code after upgrading beyond stable snapcraft#4666. The one-file cleanup passed all CI checks and received approval. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged test cleanup after upgrading to a stable snapcraft version. Removes six lines of outdated test code. Approved by one reviewer, passed all CI checks, and successfully merged. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. The change cleans up the test suite following an upgrade to a stable snapcraft version, removing legacy workarounds and aligning tests with the updated dependency. |
Update history
No update history recorded yet.
Related work
-
Related To:
canonical/snapcraft#4666
(confidence 100%)
Merged as commit 10352d96d and identified by snapcraft-rocks#85 as the prerequisite stable Snapcraft change.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1877 tests: move test files out of the snapcraft dir | snapcraft | closed | Closed unmerged after conflicts; the test reorganization was redone and merged via snapcraft#1948 at commit 55ad11ccc, moving tests out of the snapcraft package. | |
| #1849 tests: add snap not found tests | snapcraft | merged | Merged missing-snap test coverage; snapcraft PR #1849 landed as commit 54cf2bd9e. | |
| #3609 tests: move legacy snapcraft tests (CRAFT-728) | snapcraft | merged | Merged PR #3609 in commit a71aeff54, moving snapcraft_legacy unit tests from tests/unit to tests/legacy to match the package rename. | |
| #5601 Fix errors in test template | snapcraft | closed | Fixed in canonical/snapcraft#5608 (commit 71fc80ffc): test templates now terminate services during snap removal and correctly disable unattended upgrades. | |
| #1948 tests: move test files out of the snapcraft dir | snapcraft | merged | Merged as commit 55ad11ccc: a pure test-suite reorganization (788 files, +615/-589) moving test files out of the snapcraft/ package dir into top-level tests/; approved by a maintainer and now reflected in the current tests/unit layout. | |
| #4662 fix(test): do not create 2 snapcraft.yaml and confuse location | snapcraft | merged | Merged PR #4662 as commit a50b0617a, fixing test fixture paths so tests do not create duplicate root and /snap manifests that cause ambiguous hook lookup. | |
| #98 Use `rockcraft test` to test the rocks | snapcraft-rocks | open | Maintainer-filed task to replace/augment spread tests in spread.yaml and CI workflows with `rockcraft test` so built snapcraft rocks are exercised; untouched for 421 days, no labels or discussion. | |
| #1599957 unnecessary clean on examples tests | snapcraft (launchpad) | closed | Removed the redundant clean before snaps example tests via snapcraft#637 (commit 1a92db54f), speeding tests and reducing hung clean processes. | |
| #1838 tests: fix broken rust test snap | snapcraft | merged | Merged in snapcraft#1838 as 0fe7def33, removing an unnecessary unversioned log dependency that broke the rust-with-revisions test snap. | |
| #221 Documentation refresh. | snapcraft | merged | Merged in canonical/snapcraft#221 via 08d274af5, updating six files (+237/-183) for Snapcraft 2.0 YAML keywords and lifecycle changes. |