← Back to issue list

test: cleanup test now that we have a new enough snapcraft

View original Github issue

Metadata

Project
snapcraft-rocks
Number
#85
Type
pull request
State
merged
Author
lengau
Labels
Created
Updated
Closed

Current evaluation

Merged test cleanup after upgrading to a stable snapcraft version. Removes six lines of outdated test code. Approved by one reviewer, passed all CI checks, and successfully merged.

Suggested action:

No scores available.

Issue body

https://github.com/canonical/snapcraft/pull/4666 is stable and we're upgraded past that version so we can fix this test.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged test cleanup after upgrading to a stable snapcraft version. Removes six lines of outdated test code. Approved by one reviewer, passed all CI checks, and successfully merged.
qwen3.6-35b-a3b-mtp-q6 Merged. The change cleans up the test suite following an upgrade to a stable snapcraft version, removing legacy workarounds and aligning tests with the updated dependency.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1948 tests: move test files out of the snapcraft dir snapcraft merged Merged reorganization of the test suite, moving test files out of the snapcraft directory. Approved by one reviewer, the change touched 788 files with 615 additions and 589 deletions.
78%
#3609 tests: move legacy snapcraft tests (CRAFT-728) snapcraft merged Merged following reviewer approval and passing CI. Relocated unit tests for the renamed snapcraft_legacy package to tests/legacy, modifying 313 files (+579/-564 lines).
78%
#4755 tests: fix devel base snap test snapcraft merged Merged a fix for the devel base snap test. The update ensures snapcraft correctly creates and utilizes the devel base. Approved by two reviewers, passed CI checks, and applied with a minimal one-file change.
77%
#1394 tests: document the test suites in the snapcraft repo snapcraft merged Test suite documentation added to snapcraft. Approved by two reviewers, the merge updated two files with 160 additions and 33 deletions to clarify test execution. Reviewer feedback was incorporated prior to merging.
76%
#5529 fix: remove test artifact workaround snapcraft merged Merged a fix that removes the snapcraft test artifact location workaround, as craft-application 3.5 now handles this natively. Approved by two reviewers, passed all CI checks, and modified five files.
76%
#5163 tests: clean up fifos snapcraft merged Merged changes clean up cached FIFOs in the .tox directory that previously broke snapcraft snap builds. Approved by three reviewers with passing CI checks.
76%
#2353 tests: remove dependency on snapcraft for integration tests snapcraft merged Merged after reviewer approval and passing CI. The change removes the snapcraft dependency from integration tests to improve test independence, modifying 27 files with 956 additions and 733 deletions.
76%
#50 test: test the snapcraft actions craft-actions merged Merged adding tests for snapcraft actions, mirroring charmcraft tests. Approved by two reviewers with all CI checks passing. Updates two files with 89 additions and 1 deletion.
75%
#4662 fix(test): do not create 2 snapcraft.yaml and confuse location snapcraft merged Merged a test fix preventing duplicate snapcraft.yaml creation in conflicting root and snap directories. Resolves silent overrides and ensures hooks are detected by clarifying fixture paths. Approved and merged.
75%
#102 test: update craftctl test snapcraft-rocks merged Merged after two approvals and passing CI checks. Updates the spread test to validate the fix for snapcraft-rocks#33, modifying one file with seven added lines.
73%