← Back to issue list

[Regression] Static tests fail in Yakkety due to flake8

View original Launchpad issue

Metadata

Project
snapcraft (launchpad)
Number
#1600022
Type
issue
State
closed
Author
~tsimonq2
Labels
—
Created
Updated
Closed

Current evaluation

Fixed the Yakkety flake8 F821 regression in merged PR snapcore/snapcraft#641 (commit 96917ab8d) by correcting exception handling introduced in #632.

Resolution: closed resolved

Reason: PR snapcore/snapcraft#641 merged as commit 96917ab8d, fixing the undefined exception name and restoring static-test compatibility.

Evaluated by: mr-cal-bot

No scores available.

Issue body

The static tests fail in my Yakkety install with the following error: snapcraft/storeapi/__init__.py:405:15: F821 undefined name 'e' This was introduced after this merge: https://github.com/snapcore/snapcraft/pull/632 Leo Arias said that this is due to Yakkety's flake8, which seems to be causing this to fail.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Fixed the Yakkety flake8 F821 regression in merged PR snapcore/snapcraft#641 (commit 96917ab8d) by correcting exception handling introduced in #632.
stealth/space-bunny-alpha — closed resolved Fixed the Yakkety flake8 F821 regression in merged PR #641 (commit 96917ab8d), correcting exception handling introduced by #632.
stealth/space-bunny-alpha — closed resolved Fixed by merged PR canonical/snapcraft#641 (commit 96917ab8d), which addressed LP #1600022 and corrected exception handling causing Yakkety flake8's F821 failure.
qwen/qwen3.6-35b-a3b — — Closed without resolution. The regression stemmed from PR #632, triggering an undefined name error in flake8 on Ubuntu Yakkety due to a version mismatch. No code changes were applied.
qwen/qwen3.6-35b-a3b — — Closed without resolution. The flake8 error in Yakkety was attributed to the linter version rather than a code defect, with no fix implemented.

Update history

Date Change
created

Related work

  • Likely Fixed By: snapcore/snapcraft#641 (confidence 100%)

    Merged resolving PR, recorded as commit 96917ab8d.

  • Caused By: snapcore/snapcraft#632 (confidence 99%)

    The regression in exception handling was introduced by this earlier PR.

Related issues

Issue Project State Summary Similarity
#1745 static tests: upgrade to the newest flake8 snapcraft merged Merged PR #1745 upgraded static tests to the newest flake8 and fixed detected lint violations across nine files in commit cffca5aa4.
70%