snapcraft upload store integration tests is failing because it needs a manual review
Metadata
Current evaluation
Store upload integration test failed with StoreReviewError (manual review). Fixed in canonical/snapcraft#639 (commit ab1b1f8f2) by using a test snap eligible for automatic publishing.
Resolution: closed resolved
Reason: Referenced resolving PR canonical/snapcraft#639 was merged as commit ab1b1f8f2 "Use a snap that doesn't require a manual review for the upload test", which swapped the uploaded snap for one that passes publishing checks automatically, resolving the StoreReviewError.
Evaluated by: mr-cal-bot
No scores available.
Issue body
We need to upload a valid snap that will be published without a manual review.
https://travis-ci.org/snapcore/snapcraft/jobs/143148743
ERROR: test_upload_with_login (test_store_upload.UploadTestCase)
test_store_upload.UploadTestCase.test_upload_with_login
----------------------------------------------------------------------
testtools.testresult.real._StringException: output: {{{
Uploading u1test-169029473451589200095641924439514802438_16902947345158920009564192443951_amd64.snap.
b'Parallel unsquashfs: Using 2 processors\n1 inodes (1 blocks) to write\n\n\r[===================================================================|] 1/1 100%\n\ncreated 1 files\ncreated 2 directories\ncreated 0 symlinks\ncreated 0 devices\ncreated 0 fifos\n'
Starting new HTTPS connection (1): upload.apps.staging.ubuntu.com
"POST /unscanned-upload/ HTTP/1.1" 200 None
Starting new HTTPS connection (1): myapps.developer.staging.ubuntu.com
"POST /dev/api/snap-push/ HTTP/1.1" 202 None
Starting new HTTPS connection (1): myapps.developer.staging.ubuntu.com
"GET /dev/api/snaps/2t6W9lgiCj79UpTO5grjB9xHT9PH8PJe/builds/053a39f8-a61c-4f90-9aee-d291869310d0/status HTTP/1.1" 200 None
Starting new HTTPS connection (1): myapps.developer.staging.ubuntu.com
"GET /dev/api/snaps/2t6W9lgiCj79UpTO5grjB9xHT9PH8PJe/builds/053a39f8-a61c-4f90-9aee-d291869310d0/status HTTP/1.1" 200 None
Uploaded 'u1test-169029473451589200095641924439514802438'
Uploading u1test-169029473451589200095641924439514802438_16902947345158920009564192443951_amd64.snap [] 0%
Uploading u1test-169029473451589200095641924439514802438_16902947345158920009564192443951_amd64.snap [] 100%
Will need manual review...|
Traceback (most recent call last):
File "/home/travis/build/snapcore/snapcraft/bin/snapcraft", line 31, in <module>
snapcraft.main.main()
File "/home/travis/build/snapcore/snapcraft/snapcraft/main.py", line 202, in main
return run(args, project_options)
File "/home/travis/build/snapcore/snapcraft/snapcraft/main.py", line 245, in run
_run_store_command(args)
File "/home/travis/build/snapcore/snapcraft/snapcraft/main.py", line 280, in _run_store_command
snapcraft.upload(args['<snap-file>'])
File "/home/travis/build/snapcore/snapcraft/snapcraft/_store.py", line 111, in upload
tracker.raise_for_code()
File "/home/travis/build/snapcore/snapcraft/snapcraft/storeapi/__init__.py", line 384, in raise_for_code
raise errors.StoreReviewError(self.__content)
snapcraft.storeapi.errors.StoreReviewError: Publishing checks failed.
To release this to stable channel please request a review on the snapcraft list.
Use devmode in the edge or beta channels to disable confinement.
}}}
Traceback (most recent call last):
File "/home/travis/build/snapcore/snapcraft/integration_tests/test_store_upload.py", line 100, in test_upload_with_login
output = self.run_snapcraft(['upload', snap_file_path], project_dir)
File "/home/travis/build/snapcore/snapcraft/integration_tests/__init__.py", line 66, in run_snapcraft
stderr=subprocess.STDOUT, universal_newlines=True)
File "/usr/lib/python3.5/subprocess.py", line 626, in check_output
**kwargs).stdout
File "/usr/lib/python3.5/subprocess.py", line 708, in run
output=stdout, stderr=stderr)
subprocess.CalledProcessError: Command '['/home/travis/build/snapcore/snapcraft/bin/snapcraft', '-d', 'upload', 'u1test-169029473451589200095641924439514802438_16902947345158920009564192443951_amd64.snap']' returned non-zero exit status 1
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Store upload integration test failed with StoreReviewError (manual review). Fixed in canonical/snapcraft#639 (commit ab1b1f8f2) by using a test snap eligible for automatic publishing. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged canonical/snapcraft#639 (ab1b1f8f2) replaced the upload test snap with one eligible for automatic publishing, avoiding manual review. | |
| stealth/space-bunny-alpha | — | closed resolved | Fixed by merged PR canonical/snapcraft#639 (commit ab1b1f8f2), which replaced the upload test’s manually reviewed snap with one eligible for automatic publishing. | |
| qwen/qwen3.6-35b-a3b | — | — | Closed without resolution. The integration test failed when uploaded snaps triggered a mandatory manual review. No pre-approved snap was provided to bypass the check, leaving the issue abandoned. | |
| qwen/qwen3.6-35b-a3b | — | — | Integration tests failed because uploaded snaps required manual review. The issue was closed without comments or resolution, indicating it was abandoned or superseded by updated test infrastructure. | |
| qwen/qwen3.6-35b-a3b | — | — | Closed as abandoned. The integration test failed because the Ubuntu Store required manual review for uploaded snaps. With zero comments and closure after six days, no fix was implemented and the test was likely updated externally. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Closed and abandoned. The integration test failed because uploaded snaps required manual review, blocking automated publishing. No resolution or follow-up was provided. |
Update history
| Date | Change |
|---|---|
| created |
Related work
-
Likely Fixed By:
canonical/snapcraft#639
(confidence 98%)
Merged commit ab1b1f8f2 titled "Use a snap that doesn't require a manual review for the upload test" directly addresses the failing upload test.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1919397 snapcraft doesn't run store checks locally, causing disappointment at upload time | snapcraft (launchpad) | open | Bundled local store validation remains unimplemented; merged PR #2783 only added optional upload-time warnings when review-tools is already installed. | |
| #1602095 Uploading a snap that requires a manual review shows an error that's not great | snapcraft (launchpad) | closed | Closed after snapcraft/snapcraft#1110 merged, exposing Store API error details in the CLI so publishing-check failures provide actionable feedback. | |
| #1247 Fixing Store integration tests. | snapcraft | merged | Merged in canonical/snapcraft#1247 as 03105a6c4, updating Store integration tests and registration error handling for the new 40-character snap-name limit. |