← Back to issue list

snapcraft doesn't run store checks locally, causing disappointment at upload time

View original Launchpad issue

Metadata

Project
snapcraft (launchpad)
Number
#1919397
Type
issue
State
open
Author
~racb
Labels
craft-466
Created
Updated
Closed
—

Current evaluation

Bundled local store validation remains unimplemented; merged PR #2783 only added optional upload-time warnings when review-tools is already installed.

Suggested action: keep open

Reason: Maintainers agreed that local warnings plus an enforcement option could address the problem, and the concrete external-symlink rejection is clearly reported. However, current upload code does not invoke review-tools, and the Snap manifest does not bundle them, so PR #2783's optional warning-only integration does not resolve the request.

Evaluated by: mr-cal-bot

Impact: 55 Quick Win: 15 Complexity: 62 Confidence: 86 Actionability: 74

Issue body

I spent considerable time preparing a snap, thought it was all good, only to get this at store upload time: The store was unable to accept this snap. - package contains external symlinks: etc/rmt Expected: snapcraft runs the same checks locally as the store does Actual: I think it's going to work, and then it doesn't

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha
Impact: 55
Quick Win: 15
Complexity: 62
Confidence: 86
Actionability: 74
keep open Bundled local store validation remains unimplemented; merged PR #2783 only added optional upload-time warnings when review-tools is already installed.
stealth/space-bunny-alpha
Impact: 48
Quick Win: 11
Complexity: 68
Confidence: 88
Actionability: 72
keep open Snapcraft does not bundle or automatically enforce store review checks. Maintainers proposed warning and enforcement modes, but the requested local feedback remains unimplemented.
stealth/space-bunny-alpha
Impact: 45
Quick Win: 15
Complexity: 52
Confidence: 83
Actionability: 68
keep open Open request for local preflight checks equivalent to the Store's, after upload rejected an external symlink; no maintainer update or resolution is evident.
qwen/qwen3.8-27b
Impact: 50
Quick Win: 22
Staleness: 95
Complexity: 55
Confidence: 55
Support Request: 10
needs triage Snapcraft should run store validation checks locally (e.g. external symlinks) before upload. Issue is 5+ years old with no comments; a snapcraft lint command was later added, but no evidence it covers this specific check.
qwen/qwen3.6-35b-a3b
Staleness: 95
Complexity: 70
Confidence: 90
Support Request: 10
close stale Feature request to align local snapcraft validation with Snap Store checks to catch errors like external symlinks before upload. Unaddressed for nearly 5 years with no maintainer comments.
qwen/qwen3.6-35b-a3b
Staleness: 95
Complexity: 60
Confidence: 85
Support Request: 10
close stale Request to align snapcraft local checks with Snap Store upload validation. Untriaged, zero maintainer comments, inactive for over five years.
qwen3.6-35b-a3b-mtp-q6
Staleness: 95
Complexity: 60
Confidence: 85
Support Request: 10
close stale Request to add local validation checks to snapcraft that mirror Snap Store upload checks. Untriaged, zero comments, inactive for over five years.

Update history

Date Change
created

Related work

  • Related To: canonical/snapcraft#2783 (confidence 94%)

    Merged as 04f2a6eb1; it runs review-tools before upload only when available and reports warnings without blocking.

Related issues

Issue Project State Summary Similarity
#1600078 snapcraft upload store integration tests is failing because it needs a manual review snapcraft (launchpad) closed Store upload integration test failed with StoreReviewError (manual review). Fixed in canonical/snapcraft#639 (commit ab1b1f8f2) by using a test snap eligible for automatic publishing.
74%