← Back to issue list

[parser] Return error codes for YAML and parsing errors

View original Launchpad issue

Metadata

Project
snapcraft (launchpad)
Number
#1602394
Type
issue
State
closed
Author
~joetalbott
Labels
—
Created
Updated
Closed

Current evaluation

Parser now returns a nonzero status for YAML/wiki errors via merged snapcore/snapcraft#658 (commit bda3b100e); fallback reuse of prior origins was deferred.

Resolution: closed resolved

Reason: Merged PR snapcore/snapcraft#658, commit bda3b100e, added nonzero exit handling for parser YAML/wiki errors. The later maintainer discussion confirmed that reusing origins from prior parts files was intentionally dropped.

Evaluated by: mr-cal-bot

No scores available.

Issue body

For YAML and origin errors return 1 and publish the parts that successfully parsed. [for later] For origin errors return 2 and publish using the missing pieces from the previous parts.yaml file.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Parser now returns a nonzero status for YAML/wiki errors via merged snapcore/snapcraft#658 (commit bda3b100e); fallback reuse of prior origins was deferred.
stealth/space-bunny-alpha — closed resolved Parser now returns a nonzero status for YAML/wiki errors in merged PR #658 (commit bda3b100e); fallback to origins from prior parts files was dropped.
stealth/space-bunny-alpha — closed stale Parser error-code proposal was closed with no identified resolution; it requested exit 1 for YAML/origin errors and publication of successfully parsed parts.
qwen/qwen3.6-35b-a3b — — Closed without implementation due to inactivity. The proposed error code handling for YAML and origin parsing was abandoned, with no resolution or follow-up actions recorded.
qwen/qwen3.6-35b-a3b — — Request to return specific error codes for YAML and parsing failures was closed without implementation or discussion. No code changes were made, indicating the feature was abandoned or superseded.
qwen/qwen3.6-35b-a3b — — Closed without implementation. The proposal to return distinct error codes for YAML and parsing failures, coupled with partial publishing logic, was never addressed or merged. The issue remains abandoned.
qwen/qwen3.6-35b-a3b — — Closed without implementation. The suggested error code handling for YAML and parsing errors was not adopted or merged. The issue remains abandoned.

Update history

Date Change
created

Related work

  • Likely Fixed By: snapcore/snapcraft#658 (confidence 100%)

    The PR was merged as commit bda3b100e with the title 'parser - Return non-zero code for wiki errors.'

Related issues

Issue Project State Summary Similarity
#745 Actually return a non-zero error code on errors. snapcraft merged Merged as commit b90d53d39, making snapcraft-parser exit with status 1 on errors; status 2 for origin errors was deferred.
75%
#1616613 parser - Differentiate between wiki errors and other errors snapcraft (launchpad) closed Proposal to give snapcraft-parser distinct exit codes for wiki vs other errors was declined. Maintainer ~elopio closed it2016-12-16: no need for other values; reopen if a reason appears. Parser kept returning 1 for all errors.
72%
#1591204 The parser should fail gracefully if the index can't be found/accessed. snapcraft (launchpad) closed Graceful handling for YAML and network errors was delivered in snapcore/snapcraft#1045 after being reported here.
72%