Actually return a non-zero error code on errors.
Metadata
Current evaluation
Merged as commit b90d53d39, making snapcraft-parser exit with status 1 on errors; status 2 for origin errors was deferred.
Resolution: closed resolved
Reason: The PR merged as commit b90d53d39 after invalid wiki input was confirmed to return exit code 1. The requested exit code 2 for origin errors was explicitly deferred.
Evaluated by: mr-cal-bot
No scores available.
Issue body
LP:#1602394
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged as commit b90d53d39, making snapcraft-parser exit with status 1 on errors; status 2 for origin errors was deferred. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged canonical/snapcraft#745 (commit b90d53d39): snapcraft-parser now returns a non-zero exit code for errors. Origin-error exit code 2 was deferred to a separate issue. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #745 in commit b90d53d39, fixing snapcraft-parser to exit 1 on wiki validation errors. Exit 2 for origin errors was deferred to separate work. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged after reviewer approval and passing checks. The fix ensures the tool returns a non-zero exit code on errors. A separate issue was created for implementing exit code 2 on origin errors. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged after reviewers verified the fix correctly returns exit code 1 on errors. A separate low-priority request for exit code 2 was deferred. Approved pending CI checks, the pull request was successfully merged. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1602394 [parser] Return error codes for YAML and parsing errors | snapcraft (launchpad) | closed | Parser now returns a nonzero status for YAML/wiki errors via merged snapcore/snapcraft#658 (commit bda3b100e); fallback reuse of prior origins was deferred. | |
| #1058 Return an error code if an origin is missing a part. | snapcraft | merged | Merged snapcore/snapcraft#1058 in commit 59896524d, making missing-part errors return a nonzero exit code. | |
| #1624019 The parser shouldn't fail on an origin error | snapcraft (launchpad) | closed | Origin fetch errors no longer crash the parser, fixing Launchpad #1624019 via canonical/snapcraft#1045 (commit 66ddbf12e). |