When I try to build a snap with the wrong catkin rosdistro, there is no good error
Metadata
Current evaluation
Invalid catkin rosdistro values now produce a helpful validation error instead of an unfriendly KeyError. Fixed by merged canonical/snapcraft#851 (commit d37b7cda8).
Resolution: closed resolved
Reason: Merged PR canonical/snapcraft#851 added validation for invalid catkin rosdistro values and replaced the unfriendly failure with a helpful error. The change is recorded in commit d37b7cda8.
Evaluated by: mr-cal-bot
No scores available.
Issue body
If I use the wrong rosdistro value in a catkin plugin, it just prints the value I entered in red. Instead, it should print a nice error telling that the distro is not supported, and maybe include the list of supported ones.
To reproduce:
Go to the the ros demo in the snapcraft repo.
Add rosdistro: wtf to the yaml
$ snapcraft
"grade" property not specified: defaulting to "stable"
Preparing to pull ros-project
Pulling ros-project
'wtf'
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Invalid catkin rosdistro values now produce a helpful validation error instead of an unfriendly KeyError. Fixed by merged canonical/snapcraft#851 (commit d37b7cda8). | |
| stealth/space-bunny-alpha | — | closed resolved | Invalid catkin rosdistro values now produce a helpful error; fixed by merged PR canonical/snapcraft#851 in commit d37b7cda8. | |
| stealth/space-bunny-alpha | — | closed resolved | Unsupported catkin ROS distributions now produce a clear validation error. Fixed by merged PR #851 in commit d37b7cda8. | |
| stealth/space-bunny-alpha | — | closed resolved | Fixed in merged PR #851 (commit d37b7cda8): the catkin plugin now validates rosdistro values and reports unsupported distributions clearly. | |
| qwen/qwen3.6-35b-a3b | — | — | Closed without resolution. The catkin plugin rosdistro validation was not updated, likely abandoned due to age and zero comments. No fix or merge occurred. | |
| qwen/qwen3.6-35b-a3b | — | — | Closed without resolution or fix. The reported lack of helpful error messages for invalid catkin rosdistro values remains unaddressed. | |
| qwen/qwen3.6-35b-a3b | — | — | Closed without resolution. The requested validation and clear error messaging for invalid catkin rosdistro values were not implemented. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Closed without comments or a linked fix. The catkin plugin's invalid rosdistro error handling was not updated, leaving the issue abandoned. |
Update history
| Date | Change |
|---|---|
| created |
Related work
-
Likely Fixed By:
canonical/snapcraft#851
(confidence 100%)
Merged PR implementing the rosdistro validation fix referenced in the issue's closing comment.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #851 catkin plugin: nicely handle an invalid rosdistro. | snapcraft | merged | Merged PR #851 as d37b7cda8: the catkin plugin now validates rosdistro and reports a helpful error instead of raising an unfriendly KeyError. | |
| #1548406 Catkin plugin: Can't handle rosdep resolving to nothing | snapcraft (launchpad) | closed | Fixed by canonical/snapcraft#331, merged as commit 1c1119ce3; Catkin now treats empty rosdep output as no dependencies instead of an error. | |
| #2270 catkin, rosdep: stop using FileNotFoundErrors | snapcraft | merged | Merged PR #2270 (de1fe2725), replacing catkin and rosdep FileNotFoundError cases with SnapcraftError-derived exceptions to avoid Sentry tracebacks. |