catkin plugin: nicely handle an invalid rosdistro.
Metadata
Current evaluation
Merged PR #851 as d37b7cda8: the catkin plugin now validates rosdistro and reports a helpful error instead of raising an unfriendly KeyError.
Resolution: closed resolved
Reason: PR #851 was approved and merged as commit d37b7cda8, resolving LP #1629957 by validating rosdistro during catkin plugin creation.
Evaluated by: mr-cal-bot
No scores available.
Issue body
This PR fixes LP: [#1629957](https://bugs.launchpad.net/snapcraft/+bug/1629957) by verifying that the rosdistro is valid when creating the plugin, and providing a helpful error message if not. Without this PR, if one requests an invalid rosdistro, snapcraft dies with an unfriendly key error.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #851 as d37b7cda8: the catkin plugin now validates rosdistro and reports a helpful error instead of raising an unfriendly KeyError. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #851 (commit d37b7cda8) validates rosdistro when creating the catkin plugin, replacing the cryptic KeyError with a helpful error for invalid distributions. Fixes LP #1629957. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged changes add rosdistro validation to the catkin plugin, replacing cryptic key errors with clear messages. Approved by reviewers and passed CI. Minor refactoring feedback was noted but did not block the merge. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged rosdistro validation for the catkin plugin, replacing cryptic KeyErrors with clear error messages and resolving Launchpad bug #1629957. Reviewers approved the fix, suggesting a future refactor to move helper functions to a dedicated formatting module. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #850 catkin plugin: add `rosdistro` to help documentation. | snapcraft | merged | Merged PR #850 (commit c3817b42d) added the `rosdistro` parameter to `snapcraft help catkin` output, closing Launchpad bug #1629955. Docs-only change, 3 lines added. | |
| #1629957 When I try to build a snap with the wrong catkin rosdistro, there is no good error | snapcraft (launchpad) | closed | Invalid catkin rosdistro values now produce a helpful validation error instead of an unfriendly KeyError. Fixed by merged canonical/snapcraft#851 (commit d37b7cda8). | |
| #1715 catkin plugin: detect and gracefully handle rosinstall clashes | snapcraft | closed | Abandoned as unnecessary: recursive rosinstall fetching was supported via #1934 (6bb63bb25), and @kyrofa said clash detection offered no gain. |