← Back to issue list

Python plugins don't clean up <partdir>/packages

View original Launchpad issue

Metadata

Project
snapcraft (launchpad)
Number
#1630005
Type
issue
State
closed
Author
~kyrofa
Labels
clean
Created
Updated
Closed

Current evaluation

Fixed by canonical/snapcraft#882 (commit c54dea99d), which added clean_pull support to the Python plugins so <partdir>/packages is removed on clean; issue closed by maintainer kyrofa citing that PR.

Resolution: closed resolved

Reason: Maintainer kyrofa closed the bug with the comment 'Fix: https://github.com/snapcore/snapcraft/pull/882'; the merged commit c54dea99d made clean_pull delete the part's packages directory, so the reported stale-directory behaviour no longer occurs.

Evaluated by: mr-cal-bot

No scores available.

Issue body

The python plugins need to make sure clean_pull removes the <partdir>/packages directory.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Fixed by canonical/snapcraft#882 (commit c54dea99d), which added clean_pull support to the Python plugins so <partdir>/packages is removed on clean; issue closed by maintainer kyrofa citing that PR.
stealth/space-bunny-alpha — closed resolved Python plugin cleanup was fixed in canonical/snapcraft#882 (commit c54dea99d), making clean_pull remove the part directory's packages folder.
stealth/space-bunny-alpha — closed resolved Python plugins now remove <partdir>/packages during clean_pull, fixed by merged canonical/snapcraft#882 (commit c54dea99d).
qwen/qwen3.6-35b-a3b — — Closed. The Python plugins were updated to remove the <partdir>/packages directory during clean_pull.
qwen/qwen3.6-35b-a3b — — Python plugins were updated to ensure clean_pull removes the <partdir>/packages directory. The issue was closed after the fix was implemented.
qwen/qwen3.6-35b-a3b — — Closed. Python plugins were updated to ensure clean_pull removes the partdir/packages directory during cleanup.
qwen3.6-35b-a3b-mtp-q6 — — Closed. Python plugins were updated to clean the <partdir>/packages directory during clean_pull. No linked pull request or additional comments were provided.

Update history

Date Change
created

Related work

  • Likely Fixed By: snapcraft#882 (confidence 95%)

    Closing comment links PR #882 as the fix; commit c54dea99d introduced clean_pull support (later commit 173d0955a 'Support cleaning pull step.' touches the same area).

  • Related To: snapcraft#3077 (confidence 40%)

    Later commit 167cc98ec 'pluginhandler: skip plugin clean_pull for PluginV2 (#3077)' shows clean_pull lifecycle evolving for v2 plugins, not directly closing this 2016 bug.

Related issues

Issue Project State Summary Similarity
#882 Python plugin: remove pip packages when cleaning pull. snapcraft merged Merged PR #882 as commit c54dea99d, making Python plugin clean_pull remove <partdir>/packages and fixing LP #1630005.
78%
#1561546 Snapcraft clean removes local plugins snapcraft (launchpad) closed Clean removing local plugins was fixed by merged PR #404 (fix commit 5094d08b2), released in Snapcraft 2.6.1; the issue was closed by maintainer kyrofa with that link.
71%