← Back to issue list

pluginhandler: skip plugin clean_pull for PluginV2

View original Github issue

Metadata

Project
snapcraft
Number
#3077
Type
pull request
State
merged
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

Merged in snapcraft#3077 (commit 167cc98ec), skipping PluginV2 clean_pull calls and updating unit tests because the method no longer exists; fixes SNAPCRAFT-1JS.

Resolution: closed resolved

Reason: PR #3077 was merged as commit 167cc98ec, changing PluginV2 handling and its unit tests to avoid the removed clean_pull method.

Evaluated by: mr-cal-bot

No scores available.

Issue body

This method is not there anymore. Update unit tests, but these really need redoing. Fixes SNAPCRAFT-1JS Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com> - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged in snapcraft#3077 (commit 167cc98ec), skipping PluginV2 clean_pull calls and updating unit tests because the method no longer exists; fixes SNAPCRAFT-1JS.
stealth/space-bunny-alpha — closed resolved Merged PR #3077 (commit 167cc98ec), skipping PluginV2 clean_pull because the method no longer exists, and updated unit tests.
stealth/space-bunny-alpha — closed resolved Merged PR #3077, updating tests to skip clean_pull for PluginV2 because that method no longer exists; fixes SNAPCRAFT-1JS (commit 167cc98ec).
qwen/qwen3.6-35b-a3b — — Merged. Updated unit tests to skip plugin clean_pull for PluginV2 as the method no longer exists, fixing SNAPCRAFT-1JS.
qwen3.6-35b-a3b-mtp-q6 — — Merged a fix to skip the removed clean_pull method for PluginV2 and updated corresponding unit tests. Resolves SNAPCRAFT-1JS.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#3139 pluginhandler: run plugin commands in isolation snapcraft merged Merged in snapcraft#3139 (389c180ea), running PluginV2 commands independently for clearer errors and PluginV1-equivalent execution exceptions; fixes SNAPCRAFT-1NQ.
73%
#3211 pluginhandler: fix stage-snaps for v2 plugins snapcraft merged Merged in canonical/snapcraft#3211 (0870f1738), fixing v2 stage-snaps handling and preventing prepare_build from discarding unpacked snaps.
73%