pluginhandler: skip plugin clean_pull for PluginV2
Metadata
Current evaluation
Merged. Updated unit tests to skip plugin clean_pull for PluginV2 as the method no longer exists, fixing SNAPCRAFT-1JS.
Suggested action: —
No scores available.
Issue body
This method is not there anymore. Update unit tests, but these really
need redoing.
Fixes SNAPCRAFT-1JS
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged. Updated unit tests to skip plugin clean_pull for PluginV2 as the method no longer exists, fixing SNAPCRAFT-1JS. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a fix to skip the removed clean_pull method for PluginV2 and updated corresponding unit tests. Resolves SNAPCRAFT-1JS. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged changes to skip the removed clean_pull method for PluginV2 in the pluginhandler. Updated unit tests accordingly, resolving SNAPCRAFT-1JS. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #3139 pluginhandler: run plugin commands in isolation | snapcraft | merged | Merged updates to execute plugin commands in isolation, enhancing error reporting and matching PluginV1 behavior. Resolves SNAPCRAFT-1NQ following successful review and CI validation. | |
| #3126 pluginhandler: allow cleaning the build step | snapcraft | merged | Merged fix resolving PluginV2 part cleanup failures caused by an improper guard in the clean_build method. Approved by reviewer, passed CI, and integrated into the codebase. |