← Back to issue list

plugin tests don't need to patch repo anymore

View original Launchpad issue

Metadata

Project
snapcraft (launchpad)
Number
#1672909
Type
issue
State
closed
Author
~sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

Plugin tests no longer patch repo.Ubuntu; obsolete patching was removed by merged snapcore/snapcraft PR #1194 (commit 8d7b0ec63).

Resolution: closed resolved

Reason: PR #1194 removed the unnecessary repo.Ubuntu patch from plugin tests and was merged as commit 8d7b0ec63, directly resolving the cleanup request.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Since stage-packages are now handled in the core, plugins don't need to patch repo anymore. This is leftover code and would be good if removed

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Plugin tests no longer patch repo.Ubuntu; obsolete patching was removed by merged snapcore/snapcraft PR #1194 (commit 8d7b0ec63).
stealth/space-bunny-alpha — closed resolved Removed leftover repo.Ubuntu patch_repo calls from plugin tests after stage-packages moved into core. Fixed by merged PR #1194 (commit 8d7b0ec63), which dropped the patch everywhere except catkin tests.
stealth/space-bunny-alpha — closed resolved Obsolete repo patching was removed from plugin tests after stage-packages moved into core. Merged in canonical/snapcraft#1194 (8d7b0ec63).
qwen/qwen3.6-35b-a3b — — Closed as obsolete. Outdated repository patching code in plugin tests was removed, as stage-packages are now managed in the core.
qwen/qwen3.6-35b-a3b — — Closed and resolved by removing outdated repo patching code from plugin tests, as stage-packages are now handled in the core.
qwen/qwen3.6-35b-a3b — — Closed. Core now handles stage-packages, making plugin test repo patching obsolete. Leftover code removal was noted but never implemented.
qwen3.6-35b-a3b-mtp-q6 — — Leftover plugin test code patching the repository was removed as obsolete. Repository patching is no longer required since stage-packages are now handled in the core. The issue was closed as obsolete.

Update history

Date Change
created

Related work

  • Likely Fixed By: snapcore/snapcraft#1194 (confidence 100%)

    The linked PR removed repo.Ubuntu patching from plugin tests in commit 8d7b0ec63.

Related issues

Issue Project State Summary Similarity
#1194 tests: remove repo.Ubuntu patch for plugins snapcraft merged Merged in PR #1194 (commit 8d7b0ec63), removing obsolete plugin repo.Ubuntu test patches after stage-packages handling moved into Snapcraft core.
84%