tests: remove repo.Ubuntu patch for plugins
Metadata
Current evaluation
Merged in PR #1194 (commit 8d7b0ec63), removing obsolete plugin repo.Ubuntu test patches after stage-packages handling moved into Snapcraft core.
Resolution: closed resolved
Reason: PR #1194 was merged as commit 8d7b0ec63. It removed the unnecessary repo.Ubuntu patches while retaining the catkin-specific patch for its separate Ubuntu instance.
Evaluated by: mr-cal-bot
No scores available.
Issue body
`stage-packages` handling has been moved to the core of snapcraft so this patching is not needed anymore. We remove it for everything except the catkin tests as it uses its own Ubuntu instance to fetch in the plugin code.
LP: #1672909
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged in PR #1194 (commit 8d7b0ec63), removing obsolete plugin repo.Ubuntu test patches after stage-packages handling moved into Snapcraft core. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #1194 (commit 8d7b0ec63) removed obsolete repo.Ubuntu plugin test patches after stage-packages handling moved into Snapcraft core, leaving the patch for catkin tests. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged changes removing the repo.Ubuntu patch for plugins after stage-packages handling moved to the core. The patch remains for catkin tests. The update modified 8 files, deleting 32 lines of code. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged removal of the repo.Ubuntu patch for plugins after stage-packages handling moved to snapcraft core. The patch remains only for catkin tests, which manage their own Ubuntu instance. |
Update history
No update history recorded yet.
Related work
-
Likely Fixed By:
project#1672909
(confidence 90%)
The merged PR explicitly cites Launchpad bug #1672909.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1672909 plugin tests don't need to patch repo anymore | snapcraft (launchpad) | closed | Plugin tests no longer patch repo.Ubuntu; obsolete patching was removed by merged snapcore/snapcraft PR #1194 (commit 8d7b0ec63). | |
| #2096 tests: don't use os_release and repo from snapcraft | snapcraft | merged | Merged PR #2096 in commit 0e27e147d, replacing integration tests' use of Snapcraft's os_release and repo modules with test-specific helpers; it fixes #1982. | |
| #2716 tests: completely mock subversion tests | snapcraft | merged | Merged PR #2716 (commit 518083bb2) fully mocked the Subversion plugin unit tests in snapcraft, cutting their runtime while keeping integration tests for real behaviour. | |
| #133 Added a test to check that the snapcraft files are ignored. | snapcraft | closed | Superseded by merged PR canonical/snapcraft#137, which added the Snapcraft-file exclusion regression test and cleaned up base-plugin tests. |