← Back to issue list

tests: remove repo.Ubuntu patch for plugins

View original Github issue

Metadata

Project
snapcraft
Number
#1194
Type
pull request
State
merged
Author
sergiusens
Labels
Created
Updated
Closed

Current evaluation

Merged changes removing the repo.Ubuntu patch for plugins after stage-packages handling moved to the core. The patch remains for catkin tests. The update modified 8 files, deleting 32 lines of code.

Suggested action:

No scores available.

Issue body

`stage-packages` handling has been moved to the core of snapcraft so this patching is not needed anymore. We remove it for everything except the catkin tests as it uses its own Ubuntu instance to fetch in the plugin code. LP: #1672909 Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged changes removing the repo.Ubuntu patch for plugins after stage-packages handling moved to the core. The patch remains for catkin tests. The update modified 8 files, deleting 32 lines of code.
qwen3.6-35b-a3b-mtp-q6 Merged removal of the repo.Ubuntu patch for plugins after stage-packages handling moved to snapcraft core. The patch remains only for catkin tests, which manage their own Ubuntu instance.
qwen3.6-35b-a3b-mtp-q6 Merged removal of the repo.Ubuntu patch for plugins in tests, as stage-packages handling moved to the snapcraft core. The patch remains for catkin tests due to their independent Ubuntu instance. Resolves LP: #1672909.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1672909 plugin tests don't need to patch repo anymore snapcraft (launchpad) closed Closed and resolved by removing outdated repo patching code from plugin tests, as stage-packages are now handled in the core.
74%
#3003 repo: always use host source lists and remove those found in plugins snapcraft merged Merged after approval and CI. Central apt source merging in the Ubuntu object, removed redundant cross-release sources from catkin and colcon plugins, updated tests, and removed unused plugin references. (+39/-109 lines, 7 files)
73%