← Back to issue list

Incorrect error message when the store returns 400 on login

View original Launchpad issue

Metadata

Project
snapcraft (launchpad)
Number
#1699232
Type
issue
State
closed
Author
~nataliabidart
Labels
from-ir store
Created
Updated
Closed

Current evaluation

Fixed as a side effect of snapcore/snapcraft#1936: Snapcraft now displays messages returned by the store instead of labeling every 400 login response as an incorrect password.

Resolution: closed resolved

Reason: Maintainer ~kyrofa stated on 2018-02-16 that the behavior was fixed as a side effect of snapcore/snapcraft#1936, which shows messages from the store. The issue was closed after that resolution; standardizing on message/error_message was only a possible follow-up.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Apparently snapcraft login would return the error message "incorrect password" when the store replied with a 400 code. The message should only be shown when the response is a 401, in other cases a more verbose message should be shown and ideally the full response should be logged.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Fixed as a side effect of snapcore/snapcraft#1936: Snapcraft now displays messages returned by the store instead of labeling every 400 login response as an incorrect password.
stealth/space-bunny-alpha — closed resolved Fixed as a side effect of merged snapcore/snapcraft#1936 (688588a0d), which updated store API error handling to surface messages from non-401 responses.
stealth/space-bunny-alpha — closed stale No documented resolution was found. Later PR #3907 (8a854a8de) improved 401 login errors, but is not confirmed as this issue’s resolver.
qwen/qwen3.6-35b-a3b — — Closed. Resolved by updating login error handling to distinguish 400 from 401 responses, displaying verbose messages and logging full responses for 400 errors.
qwen/qwen3.6-35b-a3b — — Closed without resolution. The report noted snapcraft login incorrectly showed an incorrect password error for 400 store responses, requesting proper 401 handling and verbose logging for other errors.
qwen/qwen3.6-35b-a3b — — Closed without resolution. The reported login error handling discrepancy for 400 status codes was not addressed or fixed.
qwen3.6-35b-a3b-mtp-q6 — — Closed without comments or resolution details. The incorrect 400 login error message handling was not updated, indicating the report was abandoned.

Update history

Date Change
created

Related work

  • Likely Fixed By: snapcore/snapcraft#1936 (confidence 95%)

    The maintainer explicitly identified this PR as the change that fixed the misleading store error handling.

Related issues

Issue Project State Summary Similarity
#1748802 `snapcraft login` authentication failure message could be friendlier snapcraft (launchpad) closed Fixed by merged PR snapcore/snapcraft#1936 (commit 688588a0d), which made the store API surface server-supplied error text, so login failures now read "Authentication error: Failed to get unbound discharge: Provided email/password is not correct."
78%
#1622635 Cryptic error message for store access failure. snapcraft (launchpad) closed Request for a clearer 401 error suggesting 'snapcraft login' was closed as unnecessary after PR canonical/snapcraft#903 (commit 603948e1d) removed the login requirement for Store part downloads, fixing LP #1606903.
74%
#1765671 Strange technical error message when querying store snapcraft (launchpad) closed Fixed by snapcore/snapcraft#2094, merged as 0d8602cc5, improving handling and presentation of Store API network errors and retries.
72%
#1856502 Obscure error message from snapcraft release when not logged in correctly snapcraft (launchpad) open Snapcraft exposed a raw 401 macaroon error from release; commit 8a854a8de (#3907) now gives invalid legacy credentials an actionable login or export-login resolution.
72%
#5536 fix(store): catch credential decoding errors snapcraft merged Merged in canonical/snapcraft#5536 (commit 3784560f3), converting malformed store credential decoding failures into a user-friendly error and updating craft-store.
71%
#6098 fix: Tweak error message about SNAPCRAFT_STORE_CREDENTIALS snapcraft merged Merged in commit ee69b79b1, clarifying that login cannot be used while SNAPCRAFT_STORE_CREDENTIALS is set and removing ambiguous wording.
71%