← Back to issue list

fix: Tweak error message about SNAPCRAFT_STORE_CREDENTIALS

View original Github issue

Metadata

Project
snapcraft
Number
#6098
Type
pull request
State
merged
Author
steinbro
Labels
Created
Updated
Closed

Current evaluation

Merged to clarify the ambiguous SNAPCRAFT_STORE_CREDENTIALS error message. The update explicitly states login fails while the variable is set, resolving user confusion. Approved by four reviewers and passed CI checks prior to merge.

Suggested action:

No scores available.

Issue body

The message "Cannot login with 'SNAPCRAFT_STORE_CREDENTIALS' set." is ambiguous and could be interpreted as either "Cannot use the set of credentials in 'SNAPCRAFT_STORE_CREDENTIALS' to login" (incorrect) or "Cannot login while 'SNAPCRAFT_STORE_CREDENTIALS' is set" (correct). This PR changes the message to the latter. This addresses feedback from @astrojuanlu in https://forum.snapcraft.io/t/cannot-snapcraft-login/50665 --- - [ ] I've followed the [contribution guidelines](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md). - [ ] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/). - [ ] I've successfully run `make lint && make test`. - [ ] I've added or updated any relevant documentation. - [ ] I've updated the relevant release notes.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged to clarify the ambiguous SNAPCRAFT_STORE_CREDENTIALS error message. The update explicitly states login fails while the variable is set, resolving user confusion. Approved by four reviewers and passed CI checks prior to merge.
qwen3.6-35b-a3b-mtp-q6 Merged a fix clarifying an ambiguous error message for SNAPCRAFT_STORE_CREDENTIALS. The updated text explicitly states login is blocked when the variable is set, addressing user feedback. A suggested positive phrasing was not adopted.
qwen3.6-35b-a3b-mtp-q6 Merged. Fixed ambiguous SNAPCRAFT_STORE_CREDENTIALS error message by clarifying login is blocked while the variable is set. A reviewer suggested a positive phrasing alternative, but the PR was merged with the original clarification.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#5536 fix(store): catch credential decoding errors snapcraft merged Merged fix that catches invalid SNAPCRAFT_STORE_CREDENTIALS decoding errors, replacing internal crashes with user-friendly messages. Updated craft-store dependency to 3.2.2 and resolved issue #5161.
78%
#356 fix(ci): correct conditional for snap publication rockcraft merged Merged a fix correcting an invalid conditional in the GitHub Actions workflow for snap publication. The change resolved an unrecognized SNAPCRAFT_STORE_CREDENTIALS variable reference in snap.yaml. Approved by three reviewers and passed CI checks.
74%
#2492 store: handle invalid snap file errors snapcraft merged Merged changes implementing error handling for corrupt or invalid snap files during package data extraction for signing or push. Approved by reviewer, passed CI checks, and successfully integrated to master, resolving SNAPCRAFT-GE.
74%
#45 auth: raise error when credentials cannot be parsed (CRAFT-812) craft-store merged Merged changes to craft-store that replace cryptic base64 decoding errors with a clear CredentialsNotParseable exception for invalid credentials. Approved by one reviewer and passed CI.
72%
#5000 WSL2: Cannot use `$SNAPCRAFT_STORE_CREDENTIALS` for login snapcraft closed Closed by author after system updates resolved the SNAPCRAFT_STORE_CREDENTIALS login failure in WSL2. No code changes were applied; the issue was fixed externally by environment updates.
72%
#1404 fix: set store config in separate environment variables. charmcraft merged Merged changes replace the CHARMCRAFT_STORE_CONFIG variable with separate environment variables, aligning configuration with Snapcraft. Approved by one reviewer, passed CI, and updated four files to implement the refactored setup.
71%
#4699 fix(log): map SNAPCRAFT_VERBOSITY_LEVEL to CRAFT snapcraft merged Merged a fix mapping SNAPCRAFT_VERBOSITY_LEVEL to CRAFT logging. Approved by three reviewers with passing test coverage. The change modifies five files, adding 30 lines and removing 4.
70%