snapcraft push returns non exit zero code if snap requires manual review
Metadata
Current evaluation
Manual-review status is printed during upload but is not raised as an error, so automation can treat an unreleased revision as a successful push.
Suggested action: keep open
Reason: The reporter explicitly expects release to fail for an unreviewed revision, and a maintainer confirmed that review occurs during push. Current notify_upload code only raises when processed status contains errors; need_manual_review is merely mapped to "will need manual review", so successful upload and failed release remain conflated.
Evaluated by: mr-cal-bot
Issue body
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha |
Impact:
50
Quick Win:
20
Complexity:
45
Confidence:
87
Actionability:
71
|
keep open | Manual-review status is printed during upload but is not raised as an error, so automation can treat an unreleased revision as a successful push. | |
| stealth/space-bunny-alpha |
Impact:
38
Quick Win:
7
Complexity:
48
Confidence:
86
Actionability:
33
|
close stale | Legacy snapcraft push returned nonzero when manual review followed an otherwise successful upload; the command has since been retired in favor of snapcraft upload. | |
| stealth/space-bunny-alpha |
Impact:
45
Quick Win:
20
Complexity:
27
Confidence:
91
Actionability:
62
|
keep open | Manual-review status is still treated as a successful upload: current code returns the revision unless processing errors exist, so automation can report success while the revision awaits review. | |
| qwen/qwen3.6-35b-a3b |
Impact:
30
Quick Win:
11
Complexity:
40
Confidence:
50
Actionability:
60
|
needs triage | snapcraft push returns non-zero exit code when snap requires manual review despite successful upload; user expects push to return 0 and release to fail. Unlabeled, no maintainer response, 8+ years old. | |
| qwen/qwen3.8-27b |
Impact:
35
Quick Win:
24
Staleness:
95
Complexity:
30
Confidence:
65
Support Request:
20
|
needs triage | snapcraft push returns non-zero exit code when a snap requires manual review despite successful upload; reporter expects zero exit code. Unlabeled, zero comments, inactive for over eight years. | |
| qwen/qwen3.6-35b-a3b |
Staleness:
98
Complexity:
10
Confidence:
85
Support Request:
5
|
close stale | Reports snapcraft push returning non-zero exit code when a snap requires manual review despite successful upload. Author expects zero exit code. Unlabeled, zero comments, inactive for over eight years. | |
| qwen/qwen3.6-35b-a3b |
Staleness:
98
Complexity:
15
Confidence:
90
Support Request:
10
|
close stale | snapcraft push returns non-zero exit code when a snap requires manual review. The report lacks maintainer engagement, labels, or comments, and remains untriaged. | |
| qwen3.6-35b-a3b-mtp-q6 |
Staleness:
98
Complexity:
15
Confidence:
90
Support Request:
10
|
close stale | Issue reports snapcraft push returning non-zero exit code when a snap requires manual review, despite successful upload. Author expects zero exit code for push. Unlabeled, no maintainer response, inactive for ~8.5 years. |
Update history
| Date | Change |
|---|---|
| created |
Related work
-
Related To:
snapcraft#1261
(confidence 92%)
Commit 85765674a and PR #1261 improved the Store's manual-review hint message, but the checked-in status handling still does not convert need_manual_review into an error.
-
Related To:
snapcraft (launchpad)#2044389
(confidence 82%)
A separate reported defect where snapcraft clean returned zero after failure, sharing the broader incorrect exit-status behavior.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #6076 Differentiate “need manual review” status in "snapcraft upload" from errors | snapcraft | open | `snapcraft upload` needs a documented, distinct outcome for revisions awaiting manual review so CI can distinguish them from failures; maintainer linked open work in #6081. |