← Back to issue list

Differentiate “need manual review” status in "snapcraft upload" from errors

View original Github issue

Metadata

Project
snapcraft
Number
#6076
Type
issue
State
open
Author
Jehan
Labels
—
Created
Updated
Closed
—

Current evaluation

`snapcraft upload` needs a documented, distinct outcome for revisions awaiting manual review so CI can distinguish them from failures; maintainer linked open work in #6081.

Suggested action: keep open

Reason: The maintainer identified #6081 as a potential solution, and the author confirmed that documented return codes should be implemented first. Although `need_manual_review` is currently only humanized for progress output and the revision is returned like other completed uploads, distinguishing it requires plumbing structured status through the store client, CLI exit handling, tests, and documentation, so this remains valid but needs implementation.

Evaluated by: mr-cal-bot

Impact: 58 Quick Win: 22 Complexity: 52 Confidence: 88 Actionability: 79

Issue body

### Check existing issues - [x] I've verified that this request isn't described by any existing issues. ### Request The `snapcraft upload` CLI tool should return a different return value when it ends with “need manual review” status, compared to actual errors. ### The problem it solves A problem we encountered on GIMP's release pipeline is that this "need manual review" status broke our pipeline (as it apparently didn’t return 0). As a consequence: 1. it stopped after uploading one out of the 2 archs; 2. a few other steps in the release procedure were made more annoying (because for failed pipelines, Gitlab won’t generate some “easy” redirection URLs used by our scripts to publish other binaries to our download infra). We still want to see real failures, but “need manual review” is not actually a failure, right? We just wait a bit to get the manual validation. So I’d like for our pipeline to still pass as success in this “manual review” case, which is why I wish to be able to react conditionally on the return value. P.S.: as initially [reported on the snapcraft forums](https://forum.snapcraft.io/t/personal-files-request-for-gimp/50315/10?u=gimp).

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha
Impact: 58
Quick Win: 22
Complexity: 52
Confidence: 88
Actionability: 79
keep open `snapcraft upload` needs a documented, distinct outcome for revisions awaiting manual review so CI can distinguish them from failures; maintainer linked open work in #6081.
qwen/qwen3.6-35b-a3b
Impact: 40
Quick Win: 20
Complexity: 30
Confidence: 75
Actionability: 70
keep open Request for `snapcraft upload` to return a distinct exit code for 'need manual review' status vs. actual errors, to avoid breaking CI pipelines.
qwen/qwen3.8-27b
Impact: 45
Quick Win: 25
Staleness: 50
Complexity: 45
Confidence: 78
Support Request: 25
keep open Feature request to differentiate 'need manual review' exit code from errors in snapcraft upload for CI pipelines. Maintainer acknowledged with two proposed solutions (distinct exit codes via #6081, and --format json). No implementation yet.
qwen/qwen3.6-35b-a3b
Staleness: 45
Complexity: 30
Confidence: 85
Support Request: 15
needs triage Request to return a distinct exit code for manual review status in snapcraft upload to prevent CI pipeline failures. Currently inactive with no labels or assignee.
qwen3.6-35b-a3b-mtp-q6
Staleness: 50
Complexity: 25
Confidence: 85
Support Request: 10
needs triage Request to return a distinct exit code for need manual review status in snapcraft upload to prevent CI pipeline failures. Maintainer suggested exit code changes or JSON output; author prefers exit codes first. Currently under discussion with no labels or assignee.

Update history

No update history recorded yet.

Related work

  • Related To: snapcraft#6081 (confidence 97%)

    Explicitly linked by the maintainer as a potential implementation; it covers return codes for different `snapcraft upload` responses and remains open.

  • Related To: snapcraft (launchpad)#1743587 (confidence 94%)

    Open issue describing the same manual-review exit-status problem for Store uploads.

Related issues

Issue Project State Summary Similarity
#1743587 snapcraft push returns non exit zero code if snap requires manual review snapcraft (launchpad) open Manual-review status is printed during upload but is not raised as an error, so automation can treat an unreleased revision as a successful push.
70%