← Back to issue list

Tar source removes src directory when pulling

View original Launchpad issue

Metadata

Project
snapcraft (launchpad)
Number
#1767753
Type
issue
State
closed
Author
~kyrofa
Labels
—
Created
Updated
Closed

Current evaluation

Tar source deleted the pulled src directory, breaking override-pull. Fixed by merged PR snapcore/snapcraft#2113 (commit 02774cd6b), which removed target cleaning from the Tar, Zip and Rpm FileBase sources.

Resolution: closed resolved

Reason: Maintainer ~kyrofa linked PR #2113, which was merged as commit 02774cd6b removing the redundant target-directory cleanup from Tar/Zip/Rpm sources now that the plugin handler does it, restoring override-pull. The issue was closed once that landed.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Normally this wouldn't be a huge issue, but it makes `override-pull` completely useless since it runs in a directory that gets removed. The pluginhandler removes the src directory now, there's no need to have tar also do it.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Tar source deleted the pulled src directory, breaking override-pull. Fixed by merged PR snapcore/snapcraft#2113 (commit 02774cd6b), which removed target cleaning from the Tar, Zip and Rpm FileBase sources.
stealth/space-bunny-alpha — closed resolved Fixed by merged PR snapcore/snapcraft#2113 (commit 02774cd6b), which stopped Tar — plus Zip and Rpm — sources from cleaning the target/src directory, so override-pull no longer runs in a removed directory (LP: #1767753).
stealth/space-bunny-alpha — closed stale Closed without a recorded fix or linked pull request after years of inactivity; the reported tar cleanup conflict was not verified as resolved.
qwen/qwen3.6-35b-a3b — — Resolved by relying on the pluginhandler to manage src directory removal, rendering the tar source's redundant deletion unnecessary. The issue was closed without modifications.
qwen/qwen3.6-35b-a3b — — Fixed by removing redundant directory cleanup from the tar source. The pluginhandler now handles src removal, resolving the override-pull breakage. Issue closed.

Update history

Date Change
created

Related work

  • Likely Fixed By: snapcraft#2113 (confidence 97%)

    Merged PR 'sources: don't clean target for FileBase sources', commit 02774cd6b, cited by the closing maintainer comment and covers Zip/Rpm too.

Related issues

Issue Project State Summary Similarity
#2113 sources: don't clean target for FileBase sources snapcraft merged Merged PR #2113 (commit 02774cd6b) removed target-directory cleaning from Tar, Zip and Rpm sources, fixing LP: #1767753 and making override-pull usable with those sources.
77%