sources: don't clean target for FileBase sources
Metadata
Current evaluation
Merged PR #2113 (commit 02774cd6b) removed target-directory cleaning from Tar, Zip and Rpm sources, fixing LP: #1767753 and making override-pull usable with those sources.
Resolution: closed resolved
Reason: The PR was approved and merged as commit 02774cd6b ("sources: don't clean target for FileBase sources (#2113)"), changing Tar/Zip/Rpm sources to no longer clean the target directory before extracting, which fixes LP bug #1767753.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?
- [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?
- [x] Have you successfully run `./runtests.sh static`?
- [x] Have you successfully run `./runtests.sh unit`?
-----
The source directory is already removed by the pluginhandler, having the sources do it is redundant and prevents `override-pull` from being useful when using those sources. This PR fixes [LP: #1767753](https://bugs.launchpad.net/snapcraft/+bug/1767753) by changing the `Tar`, `Zip`, and `Rpm` sources to no longer clean the target directory before extracting.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #2113 (commit 02774cd6b) removed target-directory cleaning from Tar, Zip and Rpm sources, fixing LP: #1767753 and making override-pull usable with those sources. | |
| stealth/space-bunny-alpha | — | closed resolved | PR #2113 merged as commit 02774cd6b: Tar, Zip and Rpm sources no longer clean the target directory before extracting, fixing LP: #1767753 and making override-pull usable with these sources. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #2113 (commit 02774cd6b) stopped Tar, Zip, and Rpm sources from cleaning the target directory, fixing LP: #1767753 and preserving override-pull. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged fix by kyrofa: Tar, Zip, and Rpm sources no longer clean the target directory before extraction. This removes redundant pluginhandler cleanup and enables override-pull, resolving LP: #1767753. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a fix removing redundant target directory cleanup from Tar, Zip, and Rpm sources. This resolves LP: #1767753 and restores override-pull functionality, as the pluginhandler already handles directory removal. |
Update history
No update history recorded yet.
Related work
-
Related To:
snapcraft (launchpad)#1767753
(confidence 92%)
Launchpad bug 'Tar source removes src directory when pulling', the bug report this PR fixes; the target dir is already removed by the plugin handler.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1767753 Tar source removes src directory when pulling | snapcraft (launchpad) | closed | Tar source deleted the pulled src directory, breaking override-pull. Fixed by merged PR snapcore/snapcraft#2113 (commit 02774cd6b), which removed target cleaning from the Tar, Zip and Rpm FileBase sources. |