← Back to issue list

Refactor snapcraft.yaml loading into ProjectInfo

View original Launchpad issue

Metadata

Project
snapcraft (launchpad)
Number
#1775849
Type
issue
State
closed
Author
~sergiusens
Labels
18.10-project-loading
Created
Updated
Closed

Current evaluation

Merged snapcore/snapcraft#2160, refactoring snapcraft.yaml loading out of Config into project loading as commit 44ae843f3.

Resolution: closed resolved

Reason: PR #2160 implemented the requested separation of concerns and was merged as commit 44ae843f3.

Evaluated by: mr-cal-bot

No scores available.

Issue body

`ProjectInfo` holds basic unmodified key/values loaded from snapcraft.yaml, it is missing the raw snapcraft.yaml for future consultation and diffing. Loading needs to happen at this stage and not further ahead in the `Config` class which needs to feed from `ProjectInfo`. Today, `Config` injects a `ProjectInfo` which is a bad separation of concerns.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged snapcore/snapcraft#2160, refactoring snapcraft.yaml loading out of Config into project loading as commit 44ae843f3.
stealth/space-bunny-alpha — closed resolved Resolved by merged PR #2160, which refactored snapcraft.yaml loading into project loading as commit 44ae843f3.
stealth/space-bunny-alpha — closed stale Proposed ProjectInfo-based snapcraft.yaml loading was closed without implementation after long inactivity and architectural changes.
qwen/qwen3.6-35b-a3b — — Closed without implementation. The proposed refactoring to load raw snapcraft.yaml into ProjectInfo was abandoned due to inactivity and architectural shifts.
qwen/qwen3.6-35b-a3b — — Closed and abandoned. The proposed refactor to load snapcraft.yaml into ProjectInfo was superseded by later architectural changes. No implementation occurred.
qwen/qwen3.6-35b-a3b — — Closed without resolution or discussion, indicating the proposed refactoring was abandoned or superseded by subsequent project changes.
qwen3.6-35b-a3b-mtp-q6 — — Refactoring snapcraft.yaml loading into ProjectInfo was closed with zero comments and no pull requests. The request appears abandoned or superseded by later changes, with no explicit resolution documented.

Update history

Date Change
created

Related work

  • Likely Fixed By: snapcore/snapcraft#2160 (confidence 100%)

    Merged commit 44ae843f3 moved snapcraft.yaml loading out of load_config.

Related issues

Issue Project State Summary Similarity
#2160 many: refactor snapcraft.yaml loading out of load_config snapcraft merged Merged PR #2160 refactored raw snapcraft.yaml loading out of load_config, landing as commit 44ae843f3.
83%