many: refactor snapcraft.yaml loading out of load_config
Metadata
Current evaluation
Merged PR #2160 refactored raw snapcraft.yaml loading out of load_config, landing as commit 44ae843f3.
Resolution: closed resolved
Reason: PR #2160 was approved and merged into master, introducing a logical separation between raw configuration loading and validated processing in commit 44ae843f3.
Evaluated by: mr-cal-bot
No scores available.
Issue body
In order to have separated logical bits and clear overlaying
communicated a logical separation is introduced between the
actual snapcraft loading in raw form and its processed/validated
form.
LP: #1775849
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?
- [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?
- [x] Have you successfully run `./runtests.sh static`?
- [x] Have you successfully run `./runtests.sh unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #2160 refactored raw snapcraft.yaml loading out of load_config, landing as commit 44ae843f3. | |
| stealth/space-bunny-alpha | — | closed resolved | PR #2160 by sergiusens merged as commit 44ae843f3, splitting raw snapcraft.yaml loading from validated processing in load_config (LP #1775849), 44 files changed. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #2160 (commit 44ae843f3) split raw snapcraft.yaml loading from its processed/validated form, refactoring it out of load_config into project_loader (LP: #1775849). Approved, 44 files changed. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #2160, separating raw snapcraft.yaml loading from validated processing in load_config, as commit 44ae843f3. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged a refactor separating raw snapcraft.yaml loading from validated processing within load_config. Approved by reviewer, passed CI checks, and integrated into master with 95.54% diff coverage. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into master as PR #2160. Refactored snapcraft.yaml loading out of load_config to separate raw parsing from processed validation. Codecov reported 95.54% diff coverage. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1775849 Refactor snapcraft.yaml loading into ProjectInfo | snapcraft (launchpad) | closed | Merged snapcore/snapcraft#2160, refactoring snapcraft.yaml loading out of Config into project loading as commit 44ae843f3. | |
| #2283 snapcraft snap: refactor override-build into a script | snapcraft | merged | PR #2283 merged as commit f9592939a, moving the Snapcraft snap's override-build logic into a script to reduce snapcraft.yaml duplication ahead of self-vendoring. | |
| #2062 packaging: simplify snapcraft.yaml | snapcraft | merged | Merged PR #2062 as commit 0ba7c13cc, simplifying snap/snapcraft.yaml (+86/-105, 4 files) to drop custom Python compilation and other components no longer needed for classic confinement after the 2.40 release. |