Catkin plugin doesn't follow project error guidelines
Metadata
Current evaluation
Catkin error handling was aligned with Snapcraft guidelines in merged PR #2255, commit c8017788d, replacing built-in exceptions with SnapcraftException.
Resolution: closed resolved
Reason: PR canonical/snapcraft#2255 was merged as commit c8017788d, updating the Catkin plugin to use SnapcraftException and explicitly resolving LP #1791743.
Evaluated by: mr-cal-bot
No scores available.
Issue body
These days, the snapcraft CLI has a base exception, but it hasn't always. The catkin plugin still isn't using it completely.
See SNAPCRAFT-33: https://sentry.io/share/issue/ca97ac1a4b7b4365b29abe1a0855e03f/
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Catkin error handling was aligned with Snapcraft guidelines in merged PR #2255, commit c8017788d, replacing built-in exceptions with SnapcraftException. | |
| stealth/space-bunny-alpha | — | closed resolved | Fixed incomplete base-exception handling by making the Catkin plugin use SnapcraftException in merged PR canonical/snapcraft#2255 (c8017788d). | |
| stealth/space-bunny-alpha | — | closed resolved | Fixed Catkin plugin error handling by merging snapcraft#2255, which changed it to use SnapcraftException (commit c8017788d). | |
| stealth/space-bunny-alpha | — | closed resolved | Fixed by merged PR #2255 (c8017788d), updating the Catkin plugin to use SnapcraftException. | |
| qwen/qwen3.6-35b-a3b | — | — | Closed without resolution. The catkin plugin still fails to fully implement snapcraft's base exception handling. No fix or pull request was submitted, indicating the report was likely abandoned or superseded. | |
| qwen/qwen3.6-35b-a3b | — | — | Closed without resolution. The catkin plugin was reported for not using the snapcraft CLI base exception, but the issue was abandoned due to inactivity. |
Update history
| Date | Change |
|---|---|
| created |
Related work
-
Likely Fixed By:
canonical/snapcraft#2255
(confidence 100%)
Merged PR #2255 implements the proposed fix in commit c8017788d.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #2255 catkin plugin: use SnapcraftException | snapcraft | merged | Merged PR #2255 as c8017788d, replacing catkin plugin built-in exceptions with SnapcraftException and fixing LP #1791743. | |
| #175 Catkin plugin: Refactor build. | snapcraft | merged | Merged in snapcraft#175 via commit 9045874fd, refactoring Catkin environment, dependency handling, build logic, source-space support, and tests. | |
| #1548370 Catkin plugin: Confusing print when dependency is an invalid package | snapcraft (launchpad) | closed | Catkin now reports a clear error for invalid dependency packages; fixed by merged canonical/snapcraft PR #330 (e44ded923). |