catkin plugin: use SnapcraftException
Metadata
Current evaluation
Merged PR #2255 as c8017788d, replacing catkin plugin built-in exceptions with SnapcraftException and fixing LP #1791743.
Resolution: closed resolved
Reason: PR #2255 was merged as commit c8017788d. Repository history identifies it as making the catkin plugin use SnapcraftException, resolving LP #1791743.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?
- [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?
- [x] Have you successfully run `./runtests.sh static`?
- [x] Have you successfully run `./runtests.sh tests/unit`?
-----
In the old days of the snapcraft CLI, we used a lot of built-in exceptions. Now that we have a base exception and are using Sentry, it's important to make sure we no longer do that. The catkin plugin, however, does. This PR resolves [LP: #1791743](https://bugs.launchpad.net/snapcraft/+bug/1791743) by fixing it.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #2255 as c8017788d, replacing catkin plugin built-in exceptions with SnapcraftException and fixing LP #1791743. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in canonical/snapcraft#2255 (c8017788d): catkin now uses SnapcraftException, fixing LP #1791743. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged update to the catkin plugin replacing built-in exceptions with SnapcraftException. Resolves Launchpad bug #1791743 and aligns error handling with Sentry integration practices. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged update replacing built-in exceptions with SnapcraftException in the catkin plugin, resolving LP: #1791743. Achieved 100% diff coverage, aligning error handling with Sentry integration standards. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1791743 Catkin plugin doesn't follow project error guidelines | snapcraft (launchpad) | closed | Catkin error handling was aligned with Snapcraft guidelines in merged PR #2255, commit c8017788d, replacing built-in exceptions with SnapcraftException. | |
| #2270 catkin, rosdep: stop using FileNotFoundErrors | snapcraft | merged | Merged PR #2270 (de1fe2725), replacing catkin and rosdep FileNotFoundError cases with SnapcraftError-derived exceptions to avoid Sentry tracebacks. | |
| #175 Catkin plugin: Refactor build. | snapcraft | merged | Merged in snapcraft#175 via commit 9045874fd, refactoring Catkin environment, dependency handling, build logic, source-space support, and tests. | |
| #1693380 Transition catkin plugin to use catkin build | snapcraft (launchpad) | closed | Superseded by merged PR canonical/snapcraft#1593 (7e31fa0dd), which added a separate beta catkin-tools plugin using catkin build while preserving catkin_make behavior. | |
| #69 catkin plugin: Put source into the snapcraft.yaml instead of the plugin | snapcraft | closed | PR #69 was closed unmerged in November 2015 after its author said the change needed more work; no fix landed. |