← Back to issue list

catkin plugin: use SnapcraftException

View original Github issue

Metadata

Project
snapcraft
Number
#2255
Type
pull request
State
merged
Author
kyrofa
Labels
Created
Updated
Closed

Current evaluation

Merged update to the catkin plugin replacing built-in exceptions with SnapcraftException. Resolves Launchpad bug #1791743 and aligns error handling with Sentry integration practices.

Suggested action:

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh tests/unit`? ----- In the old days of the snapcraft CLI, we used a lot of built-in exceptions. Now that we have a base exception and are using Sentry, it's important to make sure we no longer do that. The catkin plugin, however, does. This PR resolves [LP: #1791743](https://bugs.launchpad.net/snapcraft/+bug/1791743) by fixing it.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged update to the catkin plugin replacing built-in exceptions with SnapcraftException. Resolves Launchpad bug #1791743 and aligns error handling with Sentry integration practices.
qwen3.6-35b-a3b-mtp-q6 Merged update replacing built-in exceptions with SnapcraftException in the catkin plugin, resolving LP: #1791743. Achieved 100% diff coverage, aligning error handling with Sentry integration standards.
qwen3.6-35b-a3b-mtp-q6 Merged. Updated the catkin plugin to use SnapcraftException instead of built-in Python exceptions, standardizing error handling for Sentry integration. Resolves LP: #1791743. Successfully merged with full diff coverage.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#2270 catkin, rosdep: stop using FileNotFoundErrors snapcraft merged Merged. Replaces FileNotFoundError with SnapcraftError-derived exceptions in catkin and rosdep to prevent raw tracebacks from reaching Sentry. Ensures users receive formatted error messages. Approved by one reviewer and passed CI.
73%
#1791743 Catkin plugin doesn't follow project error guidelines snapcraft (launchpad) closed Closed without resolution. The catkin plugin still fails to fully implement snapcraft's base exception handling. No fix or pull request was submitted, indicating the report was likely abandoned or superseded.
73%