← Back to issue list

Local source change detection doesn't filter out snap/.snapcraft directory

View original Launchpad issue

Metadata

Project
snapcraft (launchpad)
Number
#1791773
Type
issue
State
closed
Author
~kyrofa
Labels
—
Created
Updated
Closed

Current evaluation

Local-source change detection now excludes the snap/.snapcraft directory; the fix was merged in canonical/snapcraft#2256 as commit abbc92427.

Resolution: closed resolved

Reason: PR canonical/snapcraft#2256 was merged as commit abbc92427, preventing .snapcraft contents from affecting local-source change and stale-part checks.

Evaluated by: mr-cal-bot

No scores available.

Issue body

When a part uses a local source pointing into the snap/ directory (never recommended and which will cause warnings), snapcraft includes the .snapcraft/state file when it determines if the state has changed, which is pretty much always true. It should be filtered out of the equation.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Local-source change detection now excludes the snap/.snapcraft directory; the fix was merged in canonical/snapcraft#2256 as commit abbc92427.
stealth/space-bunny-alpha — closed resolved Fixed local-source change detection to ignore snap/.snapcraft; merged as snapcraft#2256 in commit abbc92427.
stealth/space-bunny-alpha — closed resolved Fixed by merged PR canonical/snapcraft#2256 (commit abbc92427), excluding the .snapcraft directory from local-source change detection.
qwen/qwen3.6-35b-a3b — — Abandoned. Local source change detection incorrectly includes the .snapcraft/state directory, causing constant false change triggers. The report was closed without resolution or comments.
qwen/qwen3.6-35b-a3b — — Closed without resolution. The local source change detection bug incorrectly including the .snapcraft/state directory was abandoned.
qwen/qwen3.6-35b-a3b — — Closed without resolution. The bug persists as local source change detection still includes the .snapcraft/state directory, causing false rebuild triggers.
qwen3.6-35b-a3b-mtp-q6 — — Abandoned. Local source change detection incorrectly tracked .snapcraft/state files, causing constant false positives. Closed without comments or resolution.

Update history

Date Change
created

Related work

  • Likely Fixed By: canonical/snapcraft#2256 (confidence 100%)

    Merged PR implementing the .snapcraft directory exclusion.

Related issues

Issue Project State Summary Similarity
#2256 local source: don't include .snapcraft directory snapcraft merged Merged #2256 (commit abbc92427), fixing LP #1791773 by excluding .snapcraft from local-source copies and stale-part checks.
80%
#1558446 Pulling local sources is rather broken snapcraft (launchpad) closed Local source pull bug fixed by ubuntu-core/snapcraft PR #377 (commit eb6ad38ab "Correct local source pulling", merged as 8b4a18d9b), which inverts the isdir/rmdir checks so symlinked local sources are removed rather than raising.
72%
#1792203 Add support for snap/local directory snapcraft (launchpad) closed snap/local support was merged in canonical/snapcraft#2268 via commit 10bdb0473, allowing snap-specific local-source files and adding tests.
72%
#1816397 Modifying snapcraft.yaml with parts using local sources get dirty snapcraft (launchpad) closed Fixed in PR snapcore/snapcraft#2475 (53f96dc71): local-source dirty checks now ignore snap-directory changes, preventing manifest-only edits from rebuilding parts.
72%
#1583718 snapcraft command doesn't include expected changes snapcraft (launchpad) closed Local source edits now trigger refreshed pull/build steps, fixing stale packaged files; snapcraft#2167 was merged in commit 39c4c39f1.
71%