← Back to issue list

local source: don't include .snapcraft directory

View original Github issue

Metadata

Project
snapcraft
Number
#2256
Type
pull request
State
merged
Author
kyrofa
Labels
Created
Updated
Closed

Current evaluation

Resolved LP: #1791773 by merging a change that excludes the .snapcraft directory from copying and part staleness checks. Approved, passed CI, and merged with a six-line update across two files.

Suggested action:

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh tests/unit`? ----- This PR resolves [LP: #1791773](https://bugs.launchpad.net/snapcraft/+bug/1791773) by no longer copying the .snapcraft directory, and by no longer taking it into account when determining if a given part is out-of-date.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Resolved LP: #1791773 by merging a change that excludes the .snapcraft directory from copying and part staleness checks. Approved, passed CI, and merged with a six-line update across two files.
qwen3.6-35b-a3b-mtp-q6 Merged changes to exclude the .snapcraft directory from copying and part staleness checks, resolving Launchpad bug #1791773.
qwen3.6-35b-a3b-mtp-q6 Merged. Excludes the .snapcraft directory from local source builds, preventing it from being copied and removing it from part out-of-date checks. Resolves Launchpad bug #1791773.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1601 snapcraft.yaml: don't re-use build dir snapcraft merged Merged a fix for a source-build directory clash in snapcraft.yaml. The build directory was renamed to apt-build to avoid scriptlet conflicts. Approved by reviewers and passed CI, resolving the failure.
76%
#2502 meta: fix management of snap/local snapcraft merged Merged fix for snap/local management that prevents copying it into the snap and improves embedded directory copy logic. Approved, passed CI checks, and resolves SNAPCRAFT-J2 and SNAPCRAFT-JB.
74%
#228 packages: run snap operations silently craft-parts merged Merged to fix #218 by running snap subprocesses silently, preventing stdout leakage that conflicts with craft-cli during lifecycle execution. Approved by one reviewer, passed CI, and modified two files (+32/-15 lines).
73%
#4662 fix(test): do not create 2 snapcraft.yaml and confuse location snapcraft merged Merged a test fix preventing duplicate snapcraft.yaml creation in conflicting root and snap directories. Resolves silent overrides and ensures hooks are detected by clarifying fixture paths. Approved and merged.
73%
#161 snap: do not refresh already installed snaps craft-parts merged Merged a port of snapcraft#3617 to craft-parts. The change prevents refreshing already installed snaps by removing two lines of code. Approved by one reviewer and passed CI checks.
73%
#1100 repo: remove symlinks to libc. snapcraft merged Merged. Removes dangling libc symlinks in snapcraft to fix content sharing and staging build issues. Libraries are already in the core snap and standard paths, making the links redundant. Approved and merged. Resolves LP #1658774.
73%
#3208 snap: set PATH for snapcraft command snapcraft merged Merged to configure the PATH for the snapcraft command in the build environment, ensuring parity with launchpad buildd and destructive-mode instances. Approved, passed CI, and modified three files.
72%
#776 Updated the contents of the snapcraft init template snapcraft merged Merged update to the snapcraft init template. The maintainer modified 44 lines across three files to align with LP #1620428. Changes were integrated after a retest request, with no blocking CI failures or unresolved review comments.
72%
#535 Filter out *.snap from sourcedir snapcraft merged Merged after filtering out *.snap files from the plugin sourcedir to resolve LP: #1575628. Reviewers approved the changes following a minor unused import fix.
72%
#2167 many: detect local source changes snapcraft merged Merged. Resolves LP: #1583718 by comparing local source timestamps to pull state. Snapcraft now automatically triggers re-pulling and subsequent steps on local changes, removing manual cleaning. Approved and merged after test fixes.
72%