local source: don't include .snapcraft directory
Metadata
Current evaluation
Merged #2256 (commit abbc92427), fixing LP #1791773 by excluding .snapcraft from local-source copies and stale-part checks.
Resolution: closed resolved
Reason: Merged PR snapcore/snapcraft#2256 in commit abbc92427 stopped copying the .snapcraft directory and excluded it when determining whether a part was out of date.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?
- [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?
- [x] Have you successfully run `./runtests.sh static`?
- [x] Have you successfully run `./runtests.sh tests/unit`?
-----
This PR resolves [LP: #1791773](https://bugs.launchpad.net/snapcraft/+bug/1791773) by no longer copying the .snapcraft directory, and by no longer taking it into account when determining if a given part is out-of-date.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged #2256 (commit abbc92427), fixing LP #1791773 by excluding .snapcraft from local-source copies and stale-part checks. | |
| stealth/space-bunny-alpha | — | closed resolved | Fixed in merged PR canonical/snapcraft#2256 (commit abbc92427): local sources now exclude .snapcraft and no longer treat changes there as making a part out of date. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #2256 as commit abbc9242, resolving LP #1791773 by excluding .snapcraft from local-source copying and part out-of-date checks. | |
| qwen/qwen3.6-35b-a3b | — | — | Resolved LP: #1791773 by merging a change that excludes the .snapcraft directory from copying and part staleness checks. Approved, passed CI, and merged with a six-line update across two files. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged changes to exclude the .snapcraft directory from copying and part staleness checks, resolving Launchpad bug #1791773. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1791773 Local source change detection doesn't filter out snap/.snapcraft directory | snapcraft (launchpad) | closed | Local-source change detection now excludes the snap/.snapcraft directory; the fix was merged in canonical/snapcraft#2256 as commit abbc92427. | |
| #645 If "source: .." do not copy the current directory into itself. | snapcraft | closed | Superseded by canonical/snapcraft#725, merged as a3d662744; it fixed LP #1600428 by excluding the snapcraft.yaml directory from parent-source traversal. | |
| #622 Hard-link local sources instead of symlinking them. | snapcraft | merged | Merged in canonical/snapcraft#622 (a07fa0faa), replacing local-source symlinks with hard links and falling back to copies, fixing LP #1590108. | |
| #2289 local source: only filter out snapcraft artifacts | snapcraft | closed | Closed unmerged; #2294 superseded its approach with commit 089629e17, removing --dirty from git describe to work around LP #1662388. | |
| #1816397 Modifying snapcraft.yaml with parts using local sources get dirty | snapcraft (launchpad) | closed | Fixed in PR snapcore/snapcraft#2475 (53f96dc71): local-source dirty checks now ignore snap-directory changes, preventing manifest-only edits from rebuilding parts. | |
| #1600428 Setting source: .. causes pull to fail | snapcraft (launchpad) | closed | Fixed by snapcore/snapcraft#725, adding support for snapcraft.yaml in a subdirectory and preventing recursive source copying. | |
| #2268 sanity checks: allow snap/local dir | snapcraft | merged | Merged PR #2268 via commit 10bdb0473 allowed snapcraft-specific files under snap/local/ and added tests, resolving LP #1792203. | |
| #1644350 Runnig snapcraft with sources on parent folders (over one level) causes infinite loops | snapcraft (launchpad) | closed | Fixed by merged snapcore/snapcraft PR #926: local source traversal now excludes generated Snapcraft directories, preventing recursive copies when building from project subdirectories. | |
| #1792203 Add support for snap/local directory | snapcraft (launchpad) | closed | snap/local support was merged in canonical/snapcraft#2268 via commit 10bdb0473, allowing snap-specific local-source files and adding tests. | |
| #1827216 local source must not specify parent directories | snapcraft (launchpad) | open | Reported local-source confinement is obsolete: current craft-parts accepts relative parent paths, and Snapcraft spread tests cover sources ../.. and ../../.. |