← Back to issue list

Update the make plugin to be base aware

View original Launchpad issue

Metadata

Project
snapcraft (launchpad)
Number
#1794792
Type
issue
State
closed
Author
~sergiusens
Labels
18.10-build-vm
Created
Updated
Closed

Current evaluation

Make plugin made base aware by merged snapcore/snapcraft#2363 (commit 2f3879d93), adding core16/core18 support for the make, cmake and autotools plugins; bug closed as fixed.

Resolution: closed resolved

Reason: Maintainer ~kyrofa pointed to snapcore/snapcraft#2363, which was merged as commit 2f3879d93 "{make,cmake,autotools} plugin: add support for bases", restricting the make plugin to core16/core18 and adding base coverage in its tests and spread tests. This landed as part of the wider 18.10 plugin base-awareness sweep.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Update the plugin to be base aware.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Make plugin made base aware by merged snapcore/snapcraft#2363 (commit 2f3879d93), adding core16/core18 support for the make, cmake and autotools plugins; bug closed as fixed.
stealth/space-bunny-alpha — closed resolved Make plugin became base-aware for core16/core18 via merged snapcore/snapcraft PR #2363 (commit 2f3879d93), also updating CMake and Autotools.
stealth/space-bunny-alpha — closed resolved Make gained base support in merged PR snapcore/snapcraft#2363, commit 2f3879d93; the same change updated CMake and Autotools.
stealth/space-bunny-alpha — closed resolved Make plugin gained core16/core18 base support via merged PR #2363 (commit 2f3879d93), alongside similar CMake and Autotools updates.
stealth/space-bunny-alpha — closed stale Closed without a documented resolution; the request to make the Make plugin base-aware has no recorded comments, fix, or superseding work.
qwen/qwen3.6-35b-a3b — — Closed without comments or resolution. The request to update the make plugin for base awareness appears abandoned or superseded. No implementation details provided.
qwen/qwen3.6-35b-a3b — — Closed without recorded resolution or comments, likely abandoned or superseded.
qwen/qwen3.6-35b-a3b — — Closed without comments or resolution details. The request to update the make plugin for base awareness was abandoned.
qwen3.6-35b-a3b-mtp-q6 — — Closed without a linked resolution or pull request. The make plugin base awareness update was likely abandoned or addressed separately.

Update history

Date Change
created

Related work

  • Likely Fixed By: canonical/snapcraft#2363 (confidence 95%)

    Merged PR referenced in the closing comment; commit 2f3879d93 adds base support to the make plugin (with cmake and autotools)

  • Related To: snapcraft (launchpad)#1794780 (confidence 90%)

    Cmake plugin base-awareness bug closed by the same PR #2363

  • Related To: snapcraft#144814b29 (confidence 60%)

    Later commit 'make plugin: support for core20' extends the same base-aware make plugin

  • Related To: canonical/snapcraft#2499 (confidence 55%)

    Follow-up work 'many: support for "base: core" in snapcraft.yaml' builds on the per-plugin base support

Related issues

Issue Project State Summary Similarity
#1794777 Update the autotools plugin to be base aware snapcraft (launchpad) closed Autotools became base-aware through merged snapcraft#2363, commit 2f3879d93, adding core16/core18 support for Make, CMake, and Autotools plugins.
88%
#2363 {make,cmake,autotools} plugin: add support for bases snapcraft merged Merged #2363, adding base-aware support for the Make plugin and inherited CMake and Autotools plugins for core16/core18; commit 2f3879d93.
81%
#1794790 Update the kbuild plugin to be base aware snapcraft (launchpad) closed Closed by kyrofa pointing to snapcore/snapcraft PR #2368, merged as commit ddbda36b5 "{kbuild,kernel} plugin: add support for bases", adding core16/core18 base support to the kbuild plugin (plus its inheriting kernel plugin).
80%
#1794799 Update the qmake plugin to be base aware snapcraft (launchpad) closed Updated the qmake plugin to support bases via snapcore/snapcraft PR #2366, merged as commit 3585eb13d.
80%
#1794786 Update the gradle plugin to be base aware snapcraft (launchpad) closed Closed as done: merged snapcraft#2372 (commit 58bbbda02, "gradle plugin: add support for bases") made the Gradle plugin base-aware for core16/core18, tracked under the 18.10-build-vm milestone.
79%
#1794776 Update the ant plugin to be base aware snapcraft (launchpad) closed Ant plugin was made base-aware by merged PR snapcore/snapcraft#2370 (commit eab7fcf15), adding core16 and core18 support.
78%
#1794800 Update the ruby plugin to be base aware snapcraft (launchpad) closed Ruby plugin gained base awareness via merged PR snapcore/snapcraft#2346 (commit bdb2b85e3), adding core16/core18 support.
78%
#1794780 Update the cmake plugin to be base aware snapcraft (launchpad) closed Base-aware CMake support landed via canonical/snapcraft#2399 (commit e2f7f38e6), adding build-snap search paths.
77%
#1794801 Update the scons plugin to be base aware snapcraft (launchpad) closed Updated the SCons plugin with base awareness in snapcore/snapcraft#2357, merged as commit 883c308c9.
76%
#1794794 Update the meson plugin to be base aware snapcraft (launchpad) closed Meson plugin was made base-aware by merged PR snapcore/snapcraft#2331, commit 1e19e86a6.
76%