← Back to issue list

{make,cmake,autotools} plugin: add support for bases

View original Github issue

Metadata

Project
snapcraft
Number
#2363
Type
pull request
State
merged
Author
kyrofa
Labels
Created
Updated
Closed

Current evaluation

Merged update adds base support (core16, core18) to Make, CMake, and Autotools plugins, resolving three Launchpad bugs. Make plugin tests moved to Spread. Approved, passed CI, and achieved 100% diff coverage.

Suggested action:

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh tests/unit`? ----- This PR resolves [LP: #1794792](https://bugs.launchpad.net/snapcraft/+bug/1794792), [LP: #1794780](https://bugs.launchpad.net/snapcraft/+bug/1794780), and [LP: #1794777](https://bugs.launchpad.net/snapcraft/+bug/1794777) by updating the Make plugin (as well as the plugins that inherit from it, specifically, CMake and Autotools) to be base-aware, only supporting core16 and core18. It also moves the Make plugin integration tests into Spread.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged update adds base support (core16, core18) to Make, CMake, and Autotools plugins, resolving three Launchpad bugs. Make plugin tests moved to Spread. Approved, passed CI, and achieved 100% diff coverage.
qwen3.6-35b-a3b-mtp-q6 Merged changes updating the Make, CMake, and Autotools plugins for base awareness, limiting support to core16 and core18. Resolves three Launchpad bugs and migrates Make plugin integration tests to Spread. 100% diff coverage.
qwen3.6-35b-a3b-mtp-q6 Merged updates making the Make, CMake, and Autotools plugins base-aware, supporting only core16 and core18. Resolved three Launchpad bugs and migrated Make plugin integration tests to Spread. Achieved 100% diff coverage.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#2366 qmake plugin: add support for bases snapcraft merged Merged update to the qmake plugin adding base support for core16 and core18, resolving LP: #1794799. Includes spread tests, passed CI, and achieved 100% diff coverage.
83%
#2373 rust plugin: add support for bases snapcraft merged Merged update to the Rust plugin adding base support for core16 and core18. Resolves Launchpad bug #1798681. Approved, passed CI, and achieved 100% diff coverage with a net zero line change across 23 files.
79%
#2368 {kbuild,kernel} plugin: add support for bases snapcraft merged Merged after review and CI approval, adding core16 and core18 base support to the KBuild and Kernel plugins. Resolved Launchpad bugs #1794790 and #1794791 across 7 files with 100% diff coverage.
79%
#2362 python plugin: add support for bases snapcraft merged Merged. Updated the Python plugin to support core16 and core18 bases. Approved by reviewer, passed CI, and migrated tests to spread with 97.36% coverage.
77%
#2370 ant plugin: add support for bases snapcraft merged Merged after approval and CI. Adds base support to the ant plugin, restricting it to core16 and core18. Modifies 14 files with 83.54% diff coverage.
77%
#2357 scons plugin: add support for bases snapcraft merged Merged. Updated the Scons plugin to support core16 and core18 bases. Approved by reviewer, passed CI, and modified 105 additions and 18 deletions across five files.
76%
#2364 maven plugin: add support for bases snapcraft merged Added base awareness to the Maven plugin, supporting core16 and core18. Merged after reviewer approval and CI checks, resolving Launchpad issue #1794793. Changes modify 18 files with 778 additions and 345 deletions.
74%
#2333 catkin, catkin-tools: add support for bases snapcraft merged Merged update adding base support to catkin and catkin-tools plugins. Replaces rosdistro with automatic ROS release selection per base (Kinetic/core16, Melodic/core18). Resolves Launchpad bugs #1794778 and #1794779. Approved and merged.
74%
#2358 dotnet plugin: add support for bases snapcraft merged Merged after reviewer approval, adding base awareness to the DotNet plugin for core16. Passed CI checks and achieved 100% diff coverage across 9 modified files.
73%
#2346 ruby plugin: add support for base snapcraft merged Updates the Ruby plugin to be base-aware, restricting support to core16 and core18. Resolves bug LP: #1794800. Merged after approval, passing CI, and 100% diff coverage.
73%