{make,cmake,autotools} plugin: add support for bases
Metadata
Current evaluation
Merged #2363, adding base-aware support for the Make plugin and inherited CMake and Autotools plugins for core16/core18; commit 2f3879d93.
Resolution: closed resolved
Reason: PR #2363 was merged into master as commit 2f3879d93. It resolved Launchpad bugs #1794792, #1794780, and #1794777 and moved the Make plugin integration tests to Spread.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?
- [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?
- [x] Have you successfully run `./runtests.sh static`?
- [x] Have you successfully run `./runtests.sh tests/unit`?
-----
This PR resolves [LP: #1794792](https://bugs.launchpad.net/snapcraft/+bug/1794792), [LP: #1794780](https://bugs.launchpad.net/snapcraft/+bug/1794780), and [LP: #1794777](https://bugs.launchpad.net/snapcraft/+bug/1794777) by updating the Make plugin (as well as the plugins that inherit from it, specifically, CMake and Autotools) to be base-aware, only supporting core16 and core18. It also moves the Make plugin integration tests into Spread.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged #2363, adding base-aware support for the Make plugin and inherited CMake and Autotools plugins for core16/core18; commit 2f3879d93. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #2363 added core16/core18 base support to the Make, CMake, and Autotools plugins, resolving LP bugs #1794792, #1794780, and #1794777; Make integration tests moved to Spread. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged update adds base support (core16, core18) to Make, CMake, and Autotools plugins, resolving three Launchpad bugs. Make plugin tests moved to Spread. Approved, passed CI, and achieved 100% diff coverage. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged changes updating the Make, CMake, and Autotools plugins for base awareness, limiting support to core16 and core18. Resolves three Launchpad bugs and migrates Make plugin integration tests to Spread. 100% diff coverage. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1794777 Update the autotools plugin to be base aware | snapcraft (launchpad) | closed | Autotools became base-aware through merged snapcraft#2363, commit 2f3879d93, adding core16/core18 support for Make, CMake, and Autotools plugins. | |
| #1794792 Update the make plugin to be base aware | snapcraft (launchpad) | closed | Make plugin made base aware by merged snapcore/snapcraft#2363 (commit 2f3879d93), adding core16/core18 support for the make, cmake and autotools plugins; bug closed as fixed. | |
| #2366 qmake plugin: add support for bases | snapcraft | merged | Merged in snapcraft PR #2366 as commit 3585eb13d, making the qmake plugin base-aware for core16/core18 and adding spread tests; resolves Launchpad bug #1794799. | |
| #2357 scons plugin: add support for bases | snapcraft | merged | Merged #2357, making the Scons plugin base-aware for core16/core18; landed as commit 883c308c9 and resolved LP #1794801. | |
| #2370 ant plugin: add support for bases | snapcraft | merged | Merged via commit eab7fcf15: made the ant plugin base-aware, supporting only core16 and core18, and updated its tests/spread coverage. Closes Launchpad bug #1794776. | |
| #2368 {kbuild,kernel} plugin: add support for bases | snapcraft | merged | Merged #2368 as ddbda36b5, adding core16/core18 base support to the KBuild and inherited Kernel plugins and resolving LP bugs #1794790/#1794791. | |
| #2362 python plugin: add support for bases | snapcraft | merged | Merged in snapcraft#2362 via commit 669eebe19, making the Python plugin base-aware for core16/core18 and moving its tests to spread. | |
| #2372 gradle plugin: add support for bases | snapcraft | merged | Merged in snapcraft#2372 (58bbbda02), making the Gradle plugin base-aware with support limited to core16 and core18. | |
| #2373 rust plugin: add support for bases | snapcraft | merged | Merged PR #2373 in commit eafd6d641, making the Rust plugin base-aware for core16 and core18 and resolving LP #1798681. | |
| #1076 autotools: extend Make plugin instead of repeating code | snapcraft | merged | Merged into master: Autotools was changed to extend the Make plugin and reuse its build flow instead of duplicating logic (commit 83072a5b2). |