← Back to issue list

meson plugin: Allow duplicate items in meson-parameters

View original Launchpad issue

Metadata

Project
snapcraft (launchpad)
Number
#1803736
Type
issue
State
open
Author
~brlin
Labels
—
Created
Updated
Closed
—

Current evaluation

Legacy Snapcraft rejected duplicate meson-parameters entries; legacy was removed, and craft-parts now uses an unrestricted list that preserves duplicates.

Suggested action: close resolved

Reason: Craft-parts commit f75d994e migrated plugin properties to Pydantic, where meson-parameters is a list[str] without a uniqueness constraint, and build commands preserve every entry. Snapcraft commit ffb164b7a subsequently removed the affected snapcraft_legacy plugin, so the former JSON-schema restriction no longer exists in the supported implementation.

Evaluated by: mr-cal-bot

Impact: 28 Quick Win: 24 Complexity: 8 Confidence: 95 Actionability: 94

Issue body

It is possible that the `meson-parameters`'s value contains duplicate items, e.g., multiple `-D PROJECTOPTIONS`s resulting multiple `-D`s in the array. This patch sets the `uniqueItems` schema property to `False` to allow this syntax. Refer-to: Should the meson plugin allow non-uniqueItems? - snapcraft - snapcraft.io <https://forum.snapcraft.io/t/should-the-meson-plugin-allow-non-uniqueitems/8544>

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha
Impact: 28
Quick Win: 24
Complexity: 8
Confidence: 95
Actionability: 94
close resolved Legacy Snapcraft rejected duplicate meson-parameters entries; legacy was removed, and craft-parts now uses an unrestricted list that preserves duplicates.
stealth/space-bunny-alpha
Impact: 35
Quick Win: 20
Complexity: 28
Confidence: 86
Actionability: 78
needs triage Meson validation rejects duplicate meson-parameters, including repeated -D options. The proposed schema change remains unmerged; the legacy plugin was removed while craft-parts uses lists that preserve duplicates.
qwen/qwen3.8-27b
Impact: 30
Quick Win: 27
Staleness: 90
Complexity: 10
Confidence: 55
Support Request: 10
needs triage Feature request to allow duplicate items in meson-parameters by setting uniqueItems to False in the meson plugin schema. Related PR snapcraft#2410 was closed unmerged; fix tracked in bug #1803736. No maintainer response on the issue itself.
qwen/qwen3.6-35b-a3b
Staleness: 95
Complexity: 15
Confidence: 85
Support Request: 40
close stale Feature request to allow duplicate items in meson-parameters schema via uniqueItems=False. Unaddressed for over 7 years with zero maintainer interaction.
qwen/qwen3.6-35b-a3b
Staleness: 98
Complexity: 15
Confidence: 85
Support Request: 10
close stale Patch to allow duplicate items in meson-parameters by disabling uniqueItems schema validation. Unlabelled, zero comments, and inactive for over 7 years.
qwen3.6-35b-a3b-mtp-q6
Staleness: 98
Complexity: 15
Confidence: 85
Support Request: 10
close stale Trivial schema patch from 7.6 years ago to allow duplicate meson-parameters. Zero maintainer engagement or comments. Likely obsolete due to significant plugin/architecture changes over the past seven years.

Update history

Date Change
created

Related work

  • Related To: snapcraft#2410 (confidence 100%)

    The identical GitHub PR was closed without merge on 2018-11-16 because contribution requirements were unmet; its author was directed to this Launchpad bug.

Related issues

Issue Project State Summary Similarity
#2410 meson plugin: Allow duplicate items in meson-parameters snapcraft closed PR #2410 was closed unmerged on 2018-11-16 because contribution requirements were unmet; work was redirected to Launchpad bug #1803736.
81%