meson plugin: Allow duplicate items in meson-parameters
Metadata
Current evaluation
PR #2410 was closed unmerged on 2018-11-16 because contribution requirements were unmet; work was redirected to Launchpad bug #1803736.
Resolution: closed stale
Reason: The one-line schema change received no review or CI and was closed because contribution requirements had not been fulfilled. The closing comment directed the author to address the same defect through bug #1803736.
Evaluated by: mr-cal-bot
No scores available.
Issue body
It is possible that the `meson-parameters`'s value contains duplicate items, e.g., multiple `-D PROJECTOPTIONS`s resulting multiple `-D`s in the array. This patch sets the `uniqueItems` schema property to `False` to allow this syntax.
Refer-to: Should the meson plugin allow non-uniqueItems? - snapcraft - snapcraft.io <https://forum.snapcraft.io/t/should-the-meson-plugin-allow-non-uniqueitems/8544>
Signed-off-by: 林博仁(Buo-ren, Lin) <Buo.Ren.Lin@gmail.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?
- [ ] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed stale | PR #2410 was closed unmerged on 2018-11-16 because contribution requirements were unmet; work was redirected to Launchpad bug #1803736. | |
| stealth/space-bunny-alpha | — | closed stale | Closed without merge on 2018-11-16 because contribution requirements were unmet; the author was directed to fix Launchpad bug #1803736. | |
| stealth/space-bunny-alpha | — | closed stale | Closed unmerged because contributing requirements were unmet; bug #1803736 was filed to track allowing duplicate meson-parameters items. | |
| qwen/qwen3.6-35b-a3b | — | — | Abandoned by the author due to unmet contributing guidelines. The PR was closed without review or merge. A bug report (#1803736) was filed to track the fix, inviting other contributors to implement the schema change. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Closed without merging. Author withdrew the patch due to unmet contributing guidelines and opened bug #1803736 to track allowing duplicate items in meson-parameters. The change remains unimplemented. |
Update history
No update history recorded yet.
Related work
-
Duplicate Of:
snapcraft (launchpad)#1803736
(confidence 98%)
The closing comment identifies this bug as tracking the same meson-parameters duplicate-item issue.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1803736 meson plugin: Allow duplicate items in meson-parameters | snapcraft (launchpad) | open | Legacy Snapcraft rejected duplicate meson-parameters entries; legacy was removed, and craft-parts now uses an unrestricted list that preserves duplicates. | |
| #1294 meson plugin: Add plugin for meson build system | snapcraft | merged | Merged into master via PR #1294 (commit 0a62dc065), adding Meson build-system support; build options can be supplied through meson-parameters. |