← Back to issue list

meson plugin: Allow duplicate items in meson-parameters

View original Github issue

Metadata

Project
snapcraft
Number
#2410
Type
pull request
State
closed
Author
brlin-tw
Labels
Created
Updated
Closed

Current evaluation

Abandoned by the author due to unmet contributing guidelines. The PR was closed without review or merge. A bug report (#1803736) was filed to track the fix, inviting other contributors to implement the schema change.

Suggested action:

No scores available.

Issue body

It is possible that the `meson-parameters`'s value contains duplicate items, e.g., multiple `-D PROJECTOPTIONS`s resulting multiple `-D`s in the array. This patch sets the `uniqueItems` schema property to `False` to allow this syntax. Refer-to: Should the meson plugin allow non-uniqueItems? - snapcraft - snapcraft.io <https://forum.snapcraft.io/t/should-the-meson-plugin-allow-non-uniqueitems/8544> Signed-off-by: 林博仁(Buo-ren, Lin) <Buo.Ren.Lin@gmail.com> - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [ ] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Abandoned by the author due to unmet contributing guidelines. The PR was closed without review or merge. A bug report (#1803736) was filed to track the fix, inviting other contributors to implement the schema change.
qwen3.6-35b-a3b-mtp-q6 Closed without merging. Author withdrew the patch due to unmet contributing guidelines and opened bug #1803736 to track allowing duplicate items in meson-parameters. The change remains unimplemented.
qwen3.6-35b-a3b-mtp-q6 Closed by the author due to unfulfilled contributing guidelines. The change was abandoned, but a bug report was filed to track the fix for allowing duplicate items in meson-parameters.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1803736 meson plugin: Allow duplicate items in meson-parameters snapcraft (launchpad) open Feature request to allow duplicate items in meson-parameters by setting uniqueItems to False in the meson plugin schema. Related PR snapcraft#2410 was closed unmerged; fix tracked in bug #1803736. No maintainer response on the issue itself.
88%