← Back to issue list

Extend build provider _run signature

View original Launchpad issue

Metadata

Project
snapcraft (launchpad)
Number
#1821401
Type
issue
State
closed
Author
~sergiusens
Labels
19.04
Created
Updated
Closed

Current evaluation

Extended build-provider _run() to return command output and routed Multipass execution through it; snapcore/snapcraft#2511 merged as 46e3d1702.

Resolution: closed resolved

Reason: Resolved by snapcore/snapcraft#2511, merged as commit 46e3d1702. The change made _run() return command output and updated Multipass execution to use it.

Evaluated by: mr-cal-bot

No scores available.

Issue body

_run currently does not return output while the internal calls do. Ideally, everything inside the class that needs to run things should call _run instead of what the internal provider requires.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Extended build-provider _run() to return command output and routed Multipass execution through it; snapcore/snapcraft#2511 merged as 46e3d1702.
stealth/space-bunny-alpha — closed resolved Extended build-provider _run() to return command output and routed Multipass execution through it; PR #2511 merged as 46e3d1702.
stealth/space-bunny-alpha — closed resolved Build provider _run was updated to return output in commit 46e3d1702 via PR #2511.
qwen/qwen3.6-35b-a3b — — Proposed extending the _run method signature to return output for consistency. The request was closed without comments or implementation, indicating it was abandoned or superseded.
qwen/qwen3.6-35b-a3b — — Closed without implementation. The proposal to extend the _run signature for consistent internal provider calls was abandoned or superseded by later refactoring. No resolution or linked commits were recorded.
qwen/qwen3.6-35b-a3b — — Request to extend the _run signature for output return and internal call unification was closed without implementation. Zero comments indicate the enhancement was abandoned or superseded by subsequent code changes.
qwen3.6-35b-a3b-mtp-q6 — — Request to extend the _run signature for consistent output handling was closed without implementation. Zero comments and no linked changes indicate the request was abandoned or superseded by later refactoring.

Update history

Date Change
created

Related work

  • Likely Fixed By: snapcore/snapcraft#2511 (confidence 100%)

    The linked pull request implemented the requested _run() signature and execution-path changes.

Related issues

Issue Project State Summary Similarity
#2511 build providers: modify the _run signature snapcraft merged Merged PR #2511 (commit 46e3d1702) by maintainer sergiusens: extended build provider _run() to return command output and refactored the Multipass provider to wrap execute() instead of calling it directly.
80%