build providers: modify the _run signature
Metadata
Current evaluation
Merged PR #2511 (commit 46e3d1702) by maintainer sergiusens: extended build provider _run() to return command output and refactored the Multipass provider to wrap execute() instead of calling it directly.
Resolution: closed resolved
Reason: The PR itself was approved and merged into master as commit 46e3d1702, satisfying LP bug #1821401 by adding output return to _run and routing Multipass execution through it.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Extend the signature for _run to be able to return output. Use this
across the Multipass implementation which wraps execute instead of
calling exectute for everywhere.
LP: #1821401
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `./runtests.sh static`?
- [x] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #2511 (commit 46e3d1702) by maintainer sergiusens: extended build provider _run() to return command output and refactored the Multipass provider to wrap execute() instead of calling it directly. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #2511 in 46e3d1702, extending build-provider _run() to return output and updating Multipass to wrap execute() instead of calling it directly everywhere. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged changes modifying the _run signature in build providers to return output. Updates the Multipass implementation to wrap execute calls. Approved by reviewer and passed CI checks. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Extended the _run signature to return output, replacing direct execute calls with a wrapper across the Multipass implementation. The change passed static and unit tests, achieving 85.71% diff coverage. |
Update history
No update history recorded yet.
Related work
-
Related To:
snapcraft (launchpad)#1821401
(confidence 70%)
Launchpad bug #1821401 referenced in the PR body as the work item this implements.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1821401 Extend build provider _run signature | snapcraft (launchpad) | closed | Extended build-provider _run() to return command output and routed Multipass execution through it; snapcore/snapcraft#2511 merged as 46e3d1702. | |
| #2100 build_providers: new build provider using multipass | snapcraft | merged | Merged #2100 in commit c44a4ece9, adding the build_providers package and an MVP Multipass build provider. | |
| #2284 build providers: make use of time for multipass stop | snapcraft | merged | PR #2284 by sergiusens merged as commit fd476a4e8, fixing LP #1793288: build providers now apply a timeout ('time') to `multipass stop` so instance cleanup no longer hangs. |