← Back to issue list

build providers: modify the _run signature

View original Github issue

Metadata

Project
snapcraft
Number
#2511
Type
pull request
State
merged
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

Merged changes modifying the _run signature in build providers to return output. Updates the Multipass implementation to wrap execute calls. Approved by reviewer and passed CI checks.

Suggested action: —

No scores available.

Issue body

Extend the signature for _run to be able to return output. Use this across the Multipass implementation which wraps execute instead of calling exectute for everywhere. LP: #1821401 Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com> - [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b — — Merged changes modifying the _run signature in build providers to return output. Updates the Multipass implementation to wrap execute calls. Approved by reviewer and passed CI checks.
qwen3.6-35b-a3b-mtp-q6 — — Merged. Extended the _run signature to return output, replacing direct execute calls with a wrapper across the Multipass implementation. The change passed static and unit tests, achieving 85.71% diff coverage.
qwen3.6-35b-a3b-mtp-q6 — — Merged. Updated the _run signature to return output and applied the change across the Multipass implementation. Passed static and unit tests with 85.71% diff coverage.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#2869 build providers: use multipass from stable snapcraft merged Merged update to consume Multipass 1.0 from the stable channel for build providers. Approved by one reviewer, modifying four files with minimal changes.
81%
#491 providers: introduce multipass support (CRAFT-409) charmcraft merged Merged. Adds Multipass provider support with detection via env var, snap config, or platform default. Updates execute_run() to use pathlib.Path and adds tests. Approved by two reviewers, passed CI, and modified 10 files.
77%
#2447 build providers: remove SIGUSR1 signal ignore workaround for multipass snapcraft merged Merged removal of the SIGUSR1 signal ignore workaround for multipass following an upstream fix. The change deletes 11 lines of code, passed CI checks, and received reviewer approval.
74%
#2961 build providers: remove over use of -i in sudo snapcraft merged Merged changes removing unnecessary -i flags from sudo commands in build providers. This resolves an ioctl warning in Multipass when stdin is set to DEVNULL. Approved by one reviewer, passed CI, and modified four files.
73%
#2100 build_providers: new build provider using multipass snapcraft merged Merged pull request introducing the build_providers package and MVP multipass integration for snapcraft. Approved by two reviewers despite reported naming inconsistencies and a launch crash, accepted as initial implementation.
73%
#2284 build providers: make use of time for multipass stop snapcraft merged Updated build providers to use time for Multipass stop operations, resolving Launchpad bug #1793288. Merged after approval and passing CI checks across four files.
73%
#2288 build providers: use multipass automatically when on darwin snapcraft merged Merged. Automatically enables multipass as the build provider on macOS (darwin). Approved by a reviewer, passed CI checks, and successfully integrated.
72%
#2293 build providers: use the new snapcraft: remote for multipass snapcraft merged Merged into master. Updates the multipass build provider to use the new snapcraft: remote, removing static base mappings and delegating error handling to multipass. Approved by reviewers and passed CI.
71%
#2345 build providers: remove the qemu implementation snapcraft merged Merged the removal of the QEMU build provider implementation, superseded by multipass. The change deleted 1062 lines across 12 files after approval and passing CI checks.
70%