← Back to issue list

nodejs plugin: fix the plugin’s dependency installation

View original Github issue

Metadata

Project
snapcraft
Number
#1023
Type
pull request
State
merged
Author
jonathon-love
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #1023 as commit d3b476573, fixing the Node.js plugin’s dependency installation for LP #1652542.

Resolution: closed resolved

Reason: The fix was merged into master as commit d3b476573, completing PR #1023.

Evaluated by: mr-cal-bot

No scores available.

Issue body

LP: #1652542

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #1023 as commit d3b476573, fixing the Node.js plugin’s dependency installation for LP #1652542.
stealth/space-bunny-alpha — closed resolved Merged PR #1023 fixed Node.js plugin dependency installation; commit d3b476573 landed on master.
stealth/space-bunny-alpha — closed resolved PR snapcore/snapcraft#1023 merged into master as d3b476573, fixing Node.js plugin dependency installation (LP #1652542).
qwen/qwen3.6-35b-a3b — — Merged into master, this one-line change fixes the nodejs plugin dependency installation, resolving LP #1652542. The commit integrates cleanly with no impact on overall code coverage.
qwen3.6-35b-a3b-mtp-q6 — — Merged into master, this change fixes the nodejs plugin dependency installation. The update maintains 96.38% code coverage and resolves Launchpad bug #1652542.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#800 LP: #1623509 nodejs: fix to install dev-deps in build phase snapcraft merged Merged as commit ced6edd9c, PR #800 fixed LP #1623509 by installing package.json devDependencies during the Node.js plugin build phase.
79%
#1623509 nodejs plugin does not download dependencies from package.json snapcraft (launchpad) closed Fixed in merged PR #800 via commit ced6edd9c: the Node.js plugin now installs package.json devDependencies during the build phase.
76%
#102 NodeJS plugin snapcraft merged Merged PR #102 added the Node.js plugin; its initial implementation landed in commit 0336e05fb.
74%
#2747 nodejs plugin: fix errors when building in confinement snapcraft merged Merged in #2747 (93fd28257), fixing confined Node.js builds with npm --unsafe-perm, no SUDO_UID, build-time installation, and no npm ls for Yarn.
72%
#1232 nodejs plugin: switch to the newer LTS. (#1228) snapcraft merged Merged as commit 41fb68bb5, updating the Node.js plugin from unavailable 6.10.1 to 6.10.2 and backporting the correction from #1228.
71%
#2157 nodejs plugin: update to the latest 6.x LTS point release snapcraft merged Merged in PR #2157 via commit 4b663662, updating the Node.js plugin to the latest 6.x LTS point release.
70%