← Back to issue list

nodejs plugin: fix the plugin’s dependency installation

View original Github issue

Metadata

Project
snapcraft
Number
#1023
Type
pull request
State
merged
Author
jonathon-love
Labels
Created
Updated
Closed

Current evaluation

Merged into master, this one-line change fixes the nodejs plugin dependency installation, resolving LP #1652542. The commit integrates cleanly with no impact on overall code coverage.

Suggested action:

No scores available.

Issue body

LP: #1652542

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged into master, this one-line change fixes the nodejs plugin dependency installation, resolving LP #1652542. The commit integrates cleanly with no impact on overall code coverage.
qwen3.6-35b-a3b-mtp-q6 Merged into master, this change fixes the nodejs plugin dependency installation. The update maintains 96.38% code coverage and resolves Launchpad bug #1652542.
qwen3.6-35b-a3b-mtp-q6 Merged into master. Fixes dependency installation for the nodejs plugin. Submitted by external contributor jonathon-love, the change passed code coverage validation and was integrated without affecting overall test metrics.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#800 LP: #1623509 nodejs: fix to install dev-deps in build phase snapcraft merged Merged a fix for the nodejs plugin to install devDependencies during the build phase. Approved by a reviewer after confirming unrelated CI failures, the change was successfully integrated.
78%
#2424 nodejs plugin: fail gracefully when a package.json is missing snapcraft merged Merged into master. The nodejs plugin now fails gracefully when package.json is missing, resolving LP #1807971 and SNAPCRAFT-9X. The change adds 40 lines and removes 8 across two files, achieving 100% diff coverage.
75%
#2342 nodejs plugin: update to the latest 8.x LTS version snapcraft merged Merged into master. Updated the nodejs plugin to the latest 8.x LTS version. The change was approved, passed CI, and modified a single file with a two-line diff. Code coverage increased marginally.
74%
#2157 nodejs plugin: update to the latest 6.x LTS point release snapcraft merged Merged after approval and CI checks, updating the nodejs plugin to the latest 6.x LTS point release. The single-line change achieved 100% diff coverage with a negligible overall coverage increase.
74%
#936 nodejs plugin: install during pull to support npm run snapcraft merged Merged a nodejs plugin update that installs dependencies during pull operations. This resolves npm run command failures by ensuring required packages are available. Approved by one reviewer and modified five files.
73%
#2747 nodejs plugin: fix errors when building in confinement snapcraft merged Merged fix for nodejs plugin confinement build errors. Unsets SUDO_UID, applies --unsafe-perm to npm install, moves installation out of the pull step, and skips npm ls for yarn. Approved and merged.
72%