LP: #1623509 nodejs: fix to install dev-deps in build phase
Metadata
Current evaluation
Merged a fix for the nodejs plugin to install devDependencies during the build phase. Approved by a reviewer after confirming unrelated CI failures, the change was successfully integrated.
Suggested action: —
No scores available.
Issue body
this PR makes the nodejs plugin download the devDependencies from package.json during the build phase.
https://bugs.launchpad.net/snapcraft/+bug/1623509
i have submitted the contributor agreement as well.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged a fix for the nodejs plugin to install devDependencies during the build phase. Approved by a reviewer after confirming unrelated CI failures, the change was successfully integrated. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. The nodejs plugin now installs devDependencies during the build phase, resolving Launchpad bug #1623509. Unrelated test failures did not block the merge after the contributor agreement was submitted. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Updated the nodejs plugin to install devDependencies during the build phase, resolving Launchpad bug #1623509. Approved after confirming unrelated CI failures, the fix was successfully integrated. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1023 nodejs plugin: fix the plugin’s dependency installation | snapcraft | merged | Merged into master, this one-line change fixes the nodejs plugin dependency installation, resolving LP #1652542. The commit integrates cleanly with no impact on overall code coverage. | |
| #2747 nodejs plugin: fix errors when building in confinement | snapcraft | merged | Merged fix for nodejs plugin confinement build errors. Unsets SUDO_UID, applies --unsafe-perm to npm install, moves installation out of the pull step, and skips npm ls for yarn. Approved and merged. | |
| #936 nodejs plugin: install during pull to support npm run | snapcraft | merged | Merged a nodejs plugin update that installs dependencies during pull operations. This resolves npm run command failures by ensuring required packages are available. Approved by one reviewer and modified five files. | |
| #996 Updated nodejs plugin to use get_build_properties() | snapcraft | merged | Merged into master following reviewer approval and passing CI. The nodejs plugin now uses get_build_properties() and get_pull_properties(), with updated unit and schema tests. Code coverage increased slightly to 96.34%. |