LP: #1623509 nodejs: fix to install dev-deps in build phase
Metadata
Current evaluation
Merged as commit ced6edd9c, PR #800 fixed LP #1623509 by installing package.json devDependencies during the Node.js plugin build phase.
Resolution: closed resolved
Reason: PR #800 was approved and merged into snapcraft as commit ced6edd9c, updating the Node.js plugin to install devDependencies during the build phase.
Evaluated by: mr-cal-bot
No scores available.
Issue body
this PR makes the nodejs plugin download the devDependencies from package.json during the build phase.
https://bugs.launchpad.net/snapcraft/+bug/1623509
i have submitted the contributor agreement as well.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged as commit ced6edd9c, PR #800 fixed LP #1623509 by installing package.json devDependencies during the Node.js plugin build phase. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in snapcraft#800 (commit ced6edd9c), fixing the nodejs plugin to install package.json devDependencies during the build phase for LP #1623509. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged a fix for the nodejs plugin to install devDependencies during the build phase. Approved by a reviewer after confirming unrelated CI failures, the change was successfully integrated. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. The nodejs plugin now installs devDependencies during the build phase, resolving Launchpad bug #1623509. Unrelated test failures did not block the merge after the contributor agreement was submitted. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1623509 nodejs plugin does not download dependencies from package.json | snapcraft (launchpad) | closed | Fixed in merged PR #800 via commit ced6edd9c: the Node.js plugin now installs package.json devDependencies during the build phase. | |
| #1023 nodejs plugin: fix the plugin’s dependency installation | snapcraft | merged | Merged PR #1023 as commit d3b476573, fixing the Node.js plugin’s dependency installation for LP #1652542. |