← Back to issue list

rust plugin: add conditional compilation

View original Github issue

Metadata

Project
snapcraft
Number
#1029
Type
pull request
State
merged
Author
come-maiz
Labels
Created
Updated
Closed

Current evaluation

Merged into master, adding conditional compilation to the Rust plugin to resolve Launchpad bug #1654485. The update modified seven files (+96/-12 lines), maintained 96.36% code coverage, and integrated without reviewer approval.

Suggested action:

No scores available.

Issue body

LP: [#1654485](https://bugs.launchpad.net/snapcraft/+bug/1654485)

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged into master, adding conditional compilation to the Rust plugin to resolve Launchpad bug #1654485. The update modified seven files (+96/-12 lines), maintained 96.36% code coverage, and integrated without reviewer approval.
qwen3.6-35b-a3b-mtp-q6 Merged into master, implementing conditional compilation for the Rust plugin to resolve Launchpad bug #1654485. The change integrates with negligible coverage impact, maintaining overall test coverage at 96.36%.
qwen3.6-35b-a3b-mtp-q6 Merged into master, adding conditional compilation to the Rust plugin. Resolved Launchpad bug #1654485 and passed code coverage checks at 96.36% before integration.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#952 rust plugin: add features for conditional compilation snapcraft closed Superseded by pull request #1029, which added the requested unit tests and merged the Rust plugin conditional compilation feature. The original contribution was successfully integrated.
78%
#1654485 The rust plugin doesn't support conditional compilation snapcraft (launchpad) closed Closed without implementation due to inactivity. The Rust plugin lacks support for Cargo conditional compilation, and no resolution or merge was provided.
74%
#2373 rust plugin: add support for bases snapcraft merged Merged update to the Rust plugin adding base support for core16 and core18. Resolves Launchpad bug #1798681. Approved, passed CI, and achieved 100% diff coverage with a net zero line change across 23 files.
73%
#2170 rust plugin: fix cargo builds and run tests snapcraft merged Merged fixes for cargo builds in the Rust plugin along with new tests. The change updated two files with 41 additions and 10 deletions, achieving 100% diff coverage.
73%
#560 rust_plugin: multiple fixes craft-parts merged Merged Rust plugin fixes resolving issue #559. Changes remove unnecessary rust_channel override typing checks and improve compiler plugin identification and removal. Approved by reviewers and merged despite an unrelated CI pylint failure.
72%
#2438 rust plugin: new link for rustup snapcraft merged Merged into master after approval and passing CI. Updated the rust plugin to use a new rustup link, addressing LP #1662960. Modified 3 files with 11 additions and 6 deletions.
71%
#2431 rust plugin: update to use latest rustup command options snapcraft merged Merged update to the Rust plugin replacing deprecated rustup command options with current equivalents. Approved by a reviewer, passed CI, modified five files, and maintained 94.5% test coverage.
71%