← Back to issue list

rust plugin: add features for conditional compilation

View original Github issue

Metadata

Project
snapcraft
Number
#952
Type
pull request
State
closed
Author
cholcombe973
Labels
—
Created
Updated
Closed

Current evaluation

Conditional Rust compilation support was superseded by merged PR #1029, which added tests and landed as commit 5e6d91fa3.

Resolution: closed superseded

Reason: PR #952 remained in changes-requested state after design iterations. The implementation was completed in snapcraft#1029, merged as commit 5e6d91fa3, and resolved LP bug #1654485.

Evaluated by: mr-cal-bot

No scores available.

Issue body

This adds support for optional dependencies that can be built into the binary.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed superseded Conditional Rust compilation support was superseded by merged PR #1029, which added tests and landed as commit 5e6d91fa3.
stealth/space-bunny-alpha — closed superseded Superseded by merged PR #1029, which integrated conditional-compilation support with unit tests in commit 5e6d91fa3.
qwen/qwen3.6-35b-a3b — — Superseded by pull request #1029, which added the requested unit tests and merged the Rust plugin conditional compilation feature. The original contribution was successfully integrated.
qwen3.6-35b-a3b-mtp-q6 — — Superseded by PR #1029, which completed the Rust plugin conditional compilation feature and added required unit tests. The original contribution was closed after maintainers requested test coverage improvements.

Update history

No update history recorded yet.

Related work

  • Superseded By: snapcraft#1029 (confidence 100%)

    Merged PR containing the completed conditional-compilation implementation and unit tests.

Related issues

Issue Project State Summary Similarity
#1029 rust plugin: add conditional compilation snapcraft merged Merged Rust plugin conditional-compilation support in canonical/snapcraft#1029 via commit 5e6d91fa3, resolving LP bug #1654485.
85%
#1654485 The rust plugin doesn't support conditional compilation snapcraft (launchpad) closed Rust plugin conditional compilation was added and merged in snapcraft#1029 via commit 5e6d91fa3.
79%
#1350 rust plugin: Add support for cross-compilation snapcraft merged Merged PR #1350 added --target-arch cross-compilation support for Rust plugin parts in commit 94fb1060e.
74%
#560 rust_plugin: multiple fixes craft-parts merged Merged rust_plugin fixes: removed typing checks around the rust_channel override and added detection/removal of installed compiler plugins via the .data.rel.ro symbol. Squash-merged as fbefe6b8; fixes #559.
70%