← Back to issue list

rust plugin: add features for conditional compilation

View original Github issue

Metadata

Project
snapcraft
Number
#952
Type
pull request
State
closed
Author
cholcombe973
Labels
Created
Updated
Closed

Current evaluation

Superseded by pull request #1029, which added the requested unit tests and merged the Rust plugin conditional compilation feature. The original contribution was successfully integrated.

Suggested action:

No scores available.

Issue body

This adds support for optional dependencies that can be built into the binary.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Superseded by pull request #1029, which added the requested unit tests and merged the Rust plugin conditional compilation feature. The original contribution was successfully integrated.
qwen3.6-35b-a3b-mtp-q6 Superseded by PR #1029, which completed the Rust plugin conditional compilation feature and added required unit tests. The original contribution was closed after maintainers requested test coverage improvements.
qwen3.6-35b-a3b-mtp-q6 Superseded by pull request #1029. The Rust plugin conditional compilation feature was abandoned, with tests and final implementation completed in the follow-up PR.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1029 rust plugin: add conditional compilation snapcraft merged Merged into master, adding conditional compilation to the Rust plugin to resolve Launchpad bug #1654485. The update modified seven files (+96/-12 lines), maintained 96.36% code coverage, and integrated without reviewer approval.
78%
#2158 rust plugin: fix cargo builds and run tests snapcraft closed Changes to fix cargo builds and add tests to the Rust plugin were closed and superseded by PR #2170 after the author discovered cargo test conflicts with cross-compilation, requiring a rework.
72%
#2170 rust plugin: fix cargo builds and run tests snapcraft merged Merged fixes for cargo builds in the Rust plugin along with new tests. The change updated two files with 41 additions and 10 deletions, achieving 100% diff coverage.
70%