← Back to issue list

rust plugin: use the part source path

View original Github issue

Metadata

Project
snapcraft
Number
#1035
Type
pull request
State
merged
Author
come-maiz
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #1035 as commit 3f3673536, updating the Rust plugin to use the part source path; it was rebased after sibling PR #1034 merged.

Resolution: closed resolved

Reason: PR #1035 was approved and merged into the project as commit 3f3673536. It addressed LP bug #1654764 and followed the prerequisite Rust-plugin changes from PR #1034.

Evaluated by: mr-cal-bot

No scores available.

Issue body

LP: [#1654764](https://bugs.launchpad.net/snapcraft/+bug/1654764)

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #1035 as commit 3f3673536, updating the Rust plugin to use the part source path; it was rebased after sibling PR #1034 merged.
stealth/space-bunny-alpha — closed resolved Rust plugin was updated to use the part source path; PR #1035 merged as commit 3f3673536 after rebasing on #1034.
stealth/space-bunny-alpha — closed resolved Merged PR #1035 in commit 3f3673536, updating the Rust plugin to use the part source path. Rebased after PR #1034 was merged.
qwen/qwen3.6-35b-a3b — — Merged after resolving a conflict with PR #1034 and completing a requested rebase. The rust plugin update uses the part source path, approved by one reviewer with unchanged 96.36% code coverage.
qwen3.6-35b-a3b-mtp-q6 — — Merged into master after rebasing to resolve conflicts with PR #1034. The update modifies the Rust plugin to use the part source path, maintaining 96.36% code coverage.

Update history

No update history recorded yet.

Related work

  • Related To: snapcraft#1034 (confidence 98%)

    Sibling Rust-plugin PR merged as commit aad2d9dc0; #1035 was rebased after it.

Related issues

Issue Project State Summary Similarity
#1654764 The rust plugin is not using the Cargo.toml from the part dir snapcraft (launchpad) closed Fixed by snapcore/snapcraft#1035, merged as commit 3f3673536 "rust plugin: use the part source path", so the Rust plugin builds in the part source dir and Cargo.lock lands there instead of the repo.
76%
#2434 rust plugin: refactor to use the latest rustup snapcraft merged Merged PR #2434 in commit 3e821ca8d, updating the Rust plugin for current rustup, sharing toolchain storage, and adopting .cargo/config.
73%
#2373 rust plugin: add support for bases snapcraft merged Merged PR #2373 in commit eafd6d641, making the Rust plugin base-aware for core16 and core18 and resolving LP #1798681.
73%
#1296 rust snaps can now use source-subdir without failing on pull snapcraft merged Merged PR #1296 fixed Rust plugin pull failures with source-subdir in commit 2c957a311.
71%
#1467 rust plugin: new rustup snapcraft closed Updated the Rust plugin’s outdated rustup download link via merged PR #2438 (commit ea6caa72b), resolving LP bug #1662960.
70%