← Back to issue list

rust plugin: add support for bases

View original Github issue

Metadata

Project
snapcraft
Number
#2373
Type
pull request
State
merged
Author
kyrofa
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #2373 in commit eafd6d641, making the Rust plugin base-aware for core16 and core18 and resolving LP #1798681.

Resolution: closed resolved

Reason: The approved PR was merged as commit eafd6d641. Repository history identifies it as “rust plugin: add support for bases,” adding core16/core18 awareness and resolving LP #1798681.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [x] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? ----- This PR resolves [LP: #1798681](https://bugs.launchpad.net/snapcraft/+bug/1798681) by updating the Rust plugin to be base-aware, starting with core16 and core18.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #2373 in commit eafd6d641, making the Rust plugin base-aware for core16 and core18 and resolving LP #1798681.
stealth/space-bunny-alpha — closed resolved Merged as commit eafd6d641 ("rust plugin: add support for bases (#2373)"), making the Rust plugin base-aware for core16/core18 and resolving Launchpad bug LP#1798681; part of the wider plugin bases migration series.
stealth/space-bunny-alpha — closed resolved Merged as commit eafd6d641, making the Rust plugin base-aware for core16/core18 and resolving LP bug #1798681. Later generalised by #2499 and e3b3b8870 (get_build_base).
stealth/space-bunny-alpha — closed resolved Merged PR #2373 (commit eafd6d641), making the rust plugin base-aware for core16/core18 as part of the bases migration wave, resolving LP bug #1798681.
stealth/space-bunny-alpha — closed resolved Rust plugin base support was merged in #2373 (commit eafd6d641), adding core16/core18 awareness and resolving Launchpad bug #1798681.
qwen/qwen3.6-35b-a3b — — Merged update to the Rust plugin adding base support for core16 and core18. Resolves Launchpad bug #1798681. Approved, passed CI, and achieved 100% diff coverage with a net zero line change across 23 files.
qwen3.6-35b-a3b-mtp-q6 — — Merged updates to the Rust plugin for base awareness, supporting core16 and core18. Resolved Launchpad bug #1798681. The refactoring achieved 100% diff coverage with a net zero line change.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#2346 ruby plugin: add support for base snapcraft merged Ruby plugin base support was merged into master via #2346 (commit bdb2b85e3), adding core16/core18 support and resolving LP #1794800.
80%
#2370 ant plugin: add support for bases snapcraft merged Merged via commit eab7fcf15: made the ant plugin base-aware, supporting only core16 and core18, and updated its tests/spread coverage. Closes Launchpad bug #1794776.
80%
#2372 gradle plugin: add support for bases snapcraft merged Merged in snapcraft#2372 (58bbbda02), making the Gradle plugin base-aware with support limited to core16 and core18.
78%
#2358 dotnet plugin: add support for bases snapcraft merged Merged PR #2358 as commit 58a06ef40, making the .NET plugin base-aware and limiting support to core16.
77%
#2362 python plugin: add support for bases snapcraft merged Merged in snapcraft#2362 via commit 669eebe19, making the Python plugin base-aware for core16/core18 and moving its tests to spread.
77%
#2364 maven plugin: add support for bases snapcraft merged PR snapcraft#2364 merged as commit b4aebc678, making the Maven plugin base-aware with support for core16 and core18, resolving Launchpad bug #1794793 (18 files, +778/-345).
76%
#1798681 Update the rust plugin to be base aware snapcraft (launchpad) closed Rust plugin became base-aware via merged PR snapcore/snapcraft#2373 (commit eafd6d641), resolving Launchpad #1798681.
76%
#2357 scons plugin: add support for bases snapcraft merged Merged #2357, making the Scons plugin base-aware for core16/core18; landed as commit 883c308c9 and resolved LP #1794801.
76%
#2368 {kbuild,kernel} plugin: add support for bases snapcraft merged Merged #2368 as ddbda36b5, adding core16/core18 base support to the KBuild and inherited Kernel plugins and resolving LP bugs #1794790/#1794791.
76%
#2356 nodejs plugin: add support for bases snapcraft merged Merged PR #2356 as commit 3465f984f, making the Node.js plugin base-aware and updating npm and Yarn invocation to standard practices.
75%