← Back to issue list

meta: ensure snap.yaml is desktop free

View original Github issue

Metadata

Project
snapcraft
Number
#1053
Type
pull request
State
merged
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #1053 removes desktop-file metadata from generated snap.yaml; the fix landed in commit b72c3a3bd.

Resolution: closed resolved

Reason: The approved pull request was merged, and git history records b72c3a3bd as “meta: ensure snap.yaml is desktop free (#1053).” This confirms the cleanup shipped in the mainline code.

Evaluated by: mr-cal-bot

No scores available.

Issue body

snap.yaml has no concept of desktop files, this is a by-convention mechanism in snap. LP: #1656487 Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #1053 removes desktop-file metadata from generated snap.yaml; the fix landed in commit b72c3a3bd.
stealth/space-bunny-alpha — closed resolved Merged into master as commit b72c3a3bd; removed desktop-file references from snap.yaml and documented desktop integration as a by-convention snap mechanism.
qwen/qwen3.6-35b-a3b — — Merged into master after approval and CI. The change removes desktop file references from snap.yaml, clarifying desktop integration is a by-convention mechanism. Coverage increased slightly upon merge.
qwen3.6-35b-a3b-mtp-q6 — — Merged into master. The update ensures snap.yaml remains desktop-free, clarifying desktop files are a by-convention mechanism. Changes passed code coverage checks at 96.36% before integration.

Update history

No update history recorded yet.

Related work

  • Related To: launchpad#1656487 (confidence 100%)

    The PR description explicitly links the change to Launchpad bug #1656487.

Related issues

Issue Project State Summary Similarity
#1656487 the desktop attribute from snapcraft.yaml ends up in snap.yaml snapcraft (launchpad) closed Fixed by snapcore/snapcraft PR #1053 ("meta: ensure snap.yaml is desktop free"), merged and confirmed by osomon in Jan 2017; the desktop: key is stripped from generated meta/snap.yaml and shipped in snapcraft 2.26.
80%
#2722 meta: fixes for desktop file handling snapcraft merged Merged in snapcraft PR #2722 via dac7a776c and 81d13ed06, fixing multi-section desktop files and preserving arguments in Exec=.
73%