← Back to issue list

meta: fixes for desktop file handling

View original Github issue

Metadata

Project
snapcraft
Number
#2722
Type
pull request
State
merged
Author
cjp256
Labels
—
Created
Updated
Closed

Current evaluation

Merged in snapcraft PR #2722 via dac7a776c and 81d13ed06, fixing multi-section desktop files and preserving arguments in Exec=.

Resolution: closed resolved

Reason: The approved PR was merged with commits dac7a776c and 81d13ed06, which handle desktop files with multiple sections and preserve Exec= arguments.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Fix for desktop files with multiple sections. Fix to preserve Exec= arguments. - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged in snapcraft PR #2722 via dac7a776c and 81d13ed06, fixing multi-section desktop files and preserving arguments in Exec=.
stealth/space-bunny-alpha — closed resolved Merged desktop-file handling fixes in snapcraft#2722 via commits dac7a776c and 81d13ed06, supporting multiple sections and preserving Exec= arguments.
stealth/space-bunny-alpha — closed resolved PR #2722 merged into snapcraft: fixes desktop file handling — commits dac7a776c (handle desktop files with multiple sections) and 81d13ed06 (preserve Exec= arguments). Approved,0 unresolved comments.
stealth/space-bunny-alpha — closed resolved PR #2722 merged as commits dac7a776c and 81d13ed06, fixing desktop files with multiple sections and preserving Exec= arguments.
qwen/qwen3.6-35b-a3b — — Merged changes fixing desktop file handling for multiple sections and preserving Exec= arguments. Updates span two files (+101/-21 lines), approved by a reviewer with passing CI checks.
qwen3.6-35b-a3b-mtp-q6 — — Merged fixes for desktop file handling, addressing multiple sections and preserving Exec= arguments. The changes were integrated into the codebase. A separate user-reported issue was clarified as unrelated and resolved externally.

Update history

No update history recorded yet.

Related work

  • Related To: snapcraft#2721 (confidence 95%)

    PR discussion identifies a separate ico-handling regression addressed outside this PR.

Related issues

Issue Project State Summary Similarity
#6298 fix: allow desktop files without an Exec key snapcraft merged Merged PR #6298 (commit ea842ae55) makes Snapcraft accept desktop entries lacking an Exec key, fixing #5799; Exec reformatting now only runs when the key exists and test_missing_exec_entry was updated.
82%
#2435 Appstream desktop snapcraft merged Merged PR #2435 added AppStream-derived desktop-file support to Snapcraft, updating 10 files with 95.91% diff coverage.
74%
#1053 meta: ensure snap.yaml is desktop free snapcraft merged Merged PR #1053 removes desktop-file metadata from generated snap.yaml; the fix landed in commit b72c3a3bd.
73%
#2874 Sync fixes from snapcraft-desktop-helpers (LP-1661626 & broken XDG link) snapcraft merged Merged in #2874 as 747fe4226, fixing LP-1661626 and broken XDG dconf links for desktop parts.
73%
#1309 meta: read and write the desktop file with utf-8 encoding snapcraft merged Merged in snapcraft#1309 via commit e5751c733, fixing UTF-8 handling when reading and writing desktop files and adding integration coverage for LP #1662456.
72%
#1805431 adopt-info not finding desktop files snapcraft (launchpad) closed AppStream desktop-file lookup was fixed by merged PR snapcraft#2435 (commit 63a365159), correcting relative path resolution during extraction and metadata adoption.
71%
#1659330 Ensure that desktop file names in meta/gui/ match app names snapcraft (launchpad) closed Snapcraft now renames rewritten .desktop files in meta/gui/ to match app names (PR #1074, commit 1b97a09d3); files from setup/gui/ are left untouched. Launchpad bug #1659330 closed as fixed.
70%