← Back to issue list

meta: fixes for desktop file handling

View original Github issue

Metadata

Project
snapcraft
Number
#2722
Type
pull request
State
merged
Author
cjp256
Labels
Created
Updated
Closed

Current evaluation

Merged changes fixing desktop file handling for multiple sections and preserving Exec= arguments. Updates span two files (+101/-21 lines), approved by a reviewer with passing CI checks.

Suggested action:

No scores available.

Issue body

Fix for desktop files with multiple sections. Fix to preserve Exec= arguments. - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged changes fixing desktop file handling for multiple sections and preserving Exec= arguments. Updates span two files (+101/-21 lines), approved by a reviewer with passing CI checks.
qwen3.6-35b-a3b-mtp-q6 Merged fixes for desktop file handling, addressing multiple sections and preserving Exec= arguments. The changes were integrated into the codebase. A separate user-reported issue was clarified as unrelated and resolved externally.
qwen3.6-35b-a3b-mtp-q6 Merged. Fixes desktop file handling for multiple sections and preserves Exec= arguments. Unrelated user reports were addressed separately outside this change.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#2684 meta: decouple DesktopFile logic snapcraft merged Merged refactoring that relocates DesktopFile to meta.desktop, decouples ExtractedMetadata, and simplifies gui_dir handling. The change touches 3 files, adds 173 net lines, and increases unit test coverage by 0.07%.
76%
#4250 Added comments to indicate where the desktop-launch script source is snapcraft merged Merged after two approvals and passing CI. Adds comments clarifying the source location of the desktop-launch script for the gnome extension on core22 and later. Changes affect five files with a 0.01% coverage increase.
73%
#1010 meta: add 'desktop' entry for apps snapcraft merged Merged into master. Introduces desktop entry metadata for applications, referencing LP #1588359. Approved by one reviewer, modifies three files with a net addition of 95 lines and maintains 96.32% coverage.
73%
#1309 meta: read and write the desktop file with utf-8 encoding snapcraft merged Merged, resolving UTF-8 encoding issues when reading and writing desktop files (LP #1662456). Approved by two reviewers with 100% diff coverage. Adds an integration test and updates five files to fix the bug.
72%
#6298 fix: allow desktop files without an Exec key snapcraft merged Fixes snapcraft rejecting valid desktop files missing an Exec key by making reformatting conditional. Updates tests. Currently awaiting maintainer review with passing CI and signed CLA.
72%
#2435 Appstream desktop snapcraft merged Merged pull request adding Appstream desktop support. Approved by one reviewer with no unresolved comments. CI passed, modifying 10 files with 95.91% diff coverage.
70%