← Back to issue list

Return an error code if an origin is missing a part.

View original Github issue

Metadata

Project
snapcraft
Number
#1058
Type
pull request
State
merged
Author
josepht
Labels
—
Created
Updated
Closed

Current evaluation

Merged snapcore/snapcraft#1058 in commit 59896524d, making missing-part errors return a nonzero exit code.

Resolution: closed resolved

Reason: PR #1058 was approved and merged as commit 59896524d, which made errors for missing parts return a nonzero exit code.

Evaluated by: mr-cal-bot

No scores available.

Issue body

LP: #1618092

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged snapcore/snapcraft#1058 in commit 59896524d, making missing-part errors return a nonzero exit code.
stealth/space-bunny-alpha — closed resolved Merged into master in commit 59896524d, making missing-part errors return a nonzero exit code.
stealth/space-bunny-alpha — closed resolved Merged in #1058 (commit 59896524d), making missing-part errors return a nonzero exit code.
stealth/space-bunny-alpha — closed resolved Merged in snapcore/snapcraft#1058 via commit 59896524d, making missing-part errors return a nonzero exit code.
stealth/space-bunny-alpha — closed resolved Merged in snapcore/snapcraft#1058 (commit 59896524d): missing part errors now return a nonzero exit code.
qwen/qwen3.6-35b-a3b — — Merged into master after reviewer approval. The change returns an error code when an origin is missing a part, resolving LP #1618092. Code coverage remained stable at 96.36% with 8 net lines added across 3 files.
qwen3.6-35b-a3b-mtp-q6 — — Merged into master. Implements error code returns when an origin lacks a required part, resolving Launchpad bug #1618092. Post-merge coverage remains stable at 96.36%.

Update history

No update history recorded yet.

Related work

Related issues

Issue Project State Summary Similarity
#745 Actually return a non-zero error code on errors. snapcraft merged Merged as commit b90d53d39, making snapcraft-parser exit with status 1 on errors; status 2 for origin errors was deferred.
73%