← Back to issue list

file_utils: copy symlinks to directories as symlinks.

View original Github issue

Metadata

Project
snapcraft
Number
#1063
Type
pull request
State
merged
Author
kyrofa
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #1063 as 7768cd33b, fixing LP #1658155 by preserving directory symlinks in file_utils.link_or_copy_tree().

Resolution: closed resolved

Reason: PR #1063 was merged into master as commit 7768cd33b, making link_or_copy_tree() copy symlinks to directories as symlinks and resolving LP #1658155.

Evaluated by: mr-cal-bot

No scores available.

Issue body

This PR fixes LP: [#1658155](https://bugs.launchpad.net/snapcraft/+bug/1658155) by ensuring that `file_utils.link_or_copy_tree()` handles symlinks to directories the same way it handles symlinks to files.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #1063 as 7768cd33b, fixing LP #1658155 by preserving directory symlinks in file_utils.link_or_copy_tree().
stealth/space-bunny-alpha — closed resolved Merged as commit 7768cd33b, fixing LP #1658155 by preserving directory symlinks in file_utils.link_or_copy_tree().
qwen/qwen3.6-35b-a3b — — Merged to master, resolving Launchpad bug #1658155. Updates file_utils.link_or_copy_tree to preserve directory symlinks during copy operations. Approved by one reviewer, passed CI, and integrated with a 53-line addition across three files.
qwen3.6-35b-a3b-mtp-q6 — — Merged into master. Fixes LP #1658155 by updating file_utils.link_or_copy_tree() to preserve symlinks to directories. The change passed code coverage checks and resolved the file handling inconsistency.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1658155 file_utils.link_or_copy_tree doesn't maintain symlinks to directories snapcraft (launchpad) closed Fixed directory-symlink handling in file_utils.link_or_copy_tree by merging snapcore/snapcraft PR #1063 in commit 7768cd33b.
84%
#2674 file_utils: introduce link_or_copy_files snapcraft closed PR #2674 was closed unmerged after requested changes; the link_or_copy_files refactor and CMake artifact-collection update were abandoned.
74%