← Back to issue list

file_utils: introduce link_or_copy_files

View original Github issue

Metadata

Project
snapcraft
Number
#2674
Type
pull request
State
closed
Author
cjp256
Labels
—
Created
Updated
Closed

Current evaluation

PR #2674 was closed unmerged after requested changes; the link_or_copy_files refactor and CMake artifact-collection update were abandoned.

Resolution: closed stale

Reason: The PR record marks #2674 as closed unmerged with changes requested. No resolving commit, merged PR, or superseding reference was found, and the proposed link_or_copy_files symbol is absent from the repository.

Evaluated by: mr-cal-bot

No scores available.

Issue body

And update cmake plugin to use this common code for collecting artifacts. There are likely other areas in the code base that can use this too. - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed stale PR #2674 was closed unmerged after requested changes; the link_or_copy_files refactor and CMake artifact-collection update were abandoned.
stealth/space-bunny-alpha — closed stale PR #2674 was closed unmerged after requested changes; its link_or_copy_files helper and CMake artifact-collection refactor were abandoned without a resolving commit.
stealth/space-bunny-alpha — closed stale Closed unmerged after changes were requested; link_or_copy_files and the CMake plugin artifact-collection update were abandoned.
stealth/space-bunny-alpha — closed stale PR #2674 added link_or_copy_files and updated the CMake plugin, but was closed unmerged after changes were requested and three comments remained unresolved.
qwen/qwen3.6-35b-a3b — — Closed without merging. The PR introduced link_or_copy_files and updated the cmake plugin. A reviewer requested changes with three unresolved comments, resulting in the PR being abandoned.
qwen3.6-35b-a3b-mtp-q6 — — Closed after introducing link_or_copy_files and updating the cmake plugin for artifact collection. Codecov reported 100% diff coverage.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1063 file_utils: copy symlinks to directories as symlinks. snapcraft merged Merged PR #1063 as 7768cd33b, fixing LP #1658155 by preserving directory symlinks in file_utils.link_or_copy_tree().
74%