← Back to issue list

tests: do not rely on project_dir

View original Github issue

Metadata

Project
snapcraft
Number
#1078
Type
pull request
State
merged
Author
come-maiz
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #1078 removed tests' reliance on project_dir, resolving LP #1659356; it landed as commit 4fe0247b8.

Resolution: closed resolved

Reason: PR #1078 was approved and merged into master as commit 4fe0247b8. Its test refactor removed project_dir dependence and addressed LP #1659356.

Evaluated by: mr-cal-bot

No scores available.

Issue body

LP: [#1659356](https://bugs.launchpad.net/snapcraft/+bug/1659356)

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #1078 removed tests' reliance on project_dir, resolving LP #1659356; it landed as commit 4fe0247b8.
stealth/space-bunny-alpha — closed resolved Merged PR #1078 removed tests' reliance on project_dir, resolving LP #1659356. Merged as commit 4fe0247b8 with coverage unchanged.
qwen/qwen3.6-35b-a3b — — Merged to master, refactoring tests to remove dependency on project_dir. Approved despite 56 unresolved review comments and acknowledged minor errors. Code coverage unchanged. Resolves LP #1659356.
qwen3.6-35b-a3b-mtp-q6 — — Tests updated to remove reliance on project_dir, addressing Launchpad bug #1659356. Merged despite minor potential errors due to time constraints, with code coverage remaining stable at 96.38%.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#624 test: use `new_dir` fixture craft-parts merged Merged PR #624 as commit d214d9d8, updating two unit tests to use new_dir so test files no longer pollute the repository working directory.
76%
#3719 tests: fix lifecycle tests to run on new directory snapcraft merged Merged PR #3719 via commit 314dd7574 to run lifecycle tests in a new directory instead of the current directory.
72%
#1659356 integration tests rely on project_dir snapcraft (launchpad) closed Refactored integration tests to stop relying on project_dir; fixed by snapcore/snapcraft PR #1078 and commit 4fe0247b8.
71%
#1015 tests: reorganize command tests into subdirectory. snapcraft merged Merged PR #1015 as commit 90b63c94, moving command unit tests into a tests/unit/commands/ subdirectory (30 files, +70/-49) to shrink the unit suite and close LP #1651908.
70%