← Back to issue list

tests: reorganize command tests into subdirectory.

View original Github issue

Metadata

Project
snapcraft
Number
#1015
Type
pull request
State
merged
Author
kyrofa
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #1015 as commit 90b63c94, moving command unit tests into a tests/unit/commands/ subdirectory (30 files, +70/-49) to shrink the unit suite and close LP #1651908.

Resolution: closed resolved

Reason: The pull request was approved and merged into master as commit 90b63c94 ("tests: reorganize command tests into subdirectory (#1015)"), reorganizing command tests into a subdirectory to make the unit test suite manageable and resolve Launchpad bug #1651908.

Evaluated by: mr-cal-bot

No scores available.

Issue body

This PR resolves LP: [#1651908](https://bugs.launchpad.net/snapcraft/+bug/1651908) by making the unit test suite much more manageable.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #1015 as commit 90b63c94, moving command unit tests into a tests/unit/commands/ subdirectory (30 files, +70/-49) to shrink the unit suite and close LP #1651908.
stealth/space-bunny-alpha — closed resolved Merged PR #1015 as commit 90b63c94, reorganizing command unit tests into a subdirectory to make the suite more manageable and resolve LP #1651908.
qwen/qwen3.6-35b-a3b — — Reorganized command tests into a subdirectory to improve manageability. Merged following approval and CI checks, resolving Launchpad bug #1651908 and slightly increasing code coverage.
qwen3.6-35b-a3b-mtp-q6 — — Merged into master, reorganizing command tests into a subdirectory to improve unit test suite manageability and resolve Launchpad bug #1651908. The update added one file and three lines while maintaining 96.39% code coverage.

Update history

No update history recorded yet.

Related work

  • Related To: snapcraft#1014 (confidence 78%)

    Sibling PR merged as commit d97c00e8, reorganizing plugin tests into a subdirectory for the same LP: #1651908 umbrella cleanup effort.

Related issues

Issue Project State Summary Similarity
#1014 tests: reorganize plugin tests into subdirectory. snapcraft merged Merged #1014 as d97c00e8f, moving plugin unit tests into a dedicated subdirectory to make the suite manageable and resolve LP #1651903.
82%
#1019 tests: reorganize state tests into subdirectory. snapcraft merged Merged as commit 9abdc0dd3: six state unit test files were moved into a subdirectory, purely a test-suite reorganization with no production code changes and no coverage change (96.39%). Resolves LP#1652136.
81%
#85 tests: move starbase tests to sub-directories starbase merged Merged PR #85 as commit 43f86da, moving tests into subdirectories for isolated Starbase ownership and cleaner downstream merges.
76%
#1651908 Command tests need to be reorganized. snapcraft (launchpad) closed Command tests were moved into a dedicated subdirectory by snapcore/snapcraft PR #1015, resolving Launchpad #1651908.
75%
#3305 unit tests: fix runtests.sh not filtering tests when passed a subdirectory snapcraft merged Merged PR #3305 in e64c08aed, fixing runtests.sh to run only the requested test subdirectory instead of collecting the entire unit suite.
72%
#1638 tests: reorganize unit and integration suites to make them easier to split for travis snapcraft merged Merged #1638 as commit 30f62685c, reorganizing unit and integration test suites for easier splitting across Travis CI jobs.
72%
#1948 tests: move test files out of the snapcraft dir snapcraft merged Merged as commit 55ad11ccc: a pure test-suite reorganization (788 files, +615/-589) moving test files out of the snapcraft/ package dir into top-level tests/; approved by a maintainer and now reflected in the current tests/unit layout.
71%
#1651903 Plugin tests need to be reorganized snapcraft (launchpad) closed Fixed: plugin unit tests moved out of the monolithic tests dir into a dedicated subdirectory by merged PR snapcore/snapcraft#1014 (commit d97c00e8f), resolving LP bug #1651903.
71%
#3029 tests: speed up clean command unit tests snapcraft merged Merged PR #3029 in commit 33875c998 isolated clean-command tests from dependencies, reducing runtime from about 90 seconds to 0.5 seconds.
71%
#5375 test: fix command tests snapcraft merged Test-only PR by maintainer mr-cal merged as commit 28cb1b828 ("test: fix command tests (#5375)"), updating fixtures for failing command unit tests (CRAFT-4414); +17/-9 across 2 files, approved by 2 reviewers.
70%